Please don't look at indent-tabs-mode about ws-butler HOT 11 CLOSED

Don't have the time right now to make this conditional, add an option and a pull request. Until someone does, they can add this to their init file to remove all tab/space indent conversion.

(defun ws-butler-clean-region (beg end)
  "Delete trailing blanks in region BEG END."
  (interactive "*r")
  (ws-butler-with-save
   (narrow-to-region beg end)
   ;;  _much slower would be:       (replace-regexp "[ \t]+$" "")
   (goto-char (point-min))
   (while (not (eobp))
     (end-of-line)
     (delete-horizontal-space)
     (forward-line 1)))
  ;; clean return code for hooks
  nil)

from ws-butler.

I think this would be enough, yes, if it allows me to insert tabs (to follow the local conventions) and does not remove them.

Thanks in advance!

from ws-butler.

Thanks for this. I would personally consider not touching indentation as a sane default, as doing a covert conversion seems to conflict with the theme of the package (an unobtrusive way to trim spaces from end of line).

from ws-butler.

I used to work around this by overriding ws-butler-clean-region with one where I locally set indent-tabs-mode to t to prevent it from touching indentation, but after #17 this instead causes spaces to be replaced with tabs, so that's unfortunately no longer an option.

from ws-butler.

Thanks for the follow-up. Hopefully, this will be fixed appropriately, at some point.

Right now, I've been forced to disable ws-butler, but I miss it a lot.

from ws-butler.

Would adding a ws-butler-fix-indentation customization be enough?

Are there cases where you do want to fix indentation but want to be able to override indent-tabs-mode with something ws-butler specific?

from ws-butler.

This behaviour also interferes with smart-tabs-mode (where indent-tabs-mode must be t). ws-butler dutifully replaces all of the non-indentation spaces smart-tabs-mode has inserted with tabs. So the option to disable it would make this case work correctly, I think.

from ws-butler.

@ian-kelling This works perfectly. Thanks!

from ws-butler.

Why not just add a .dir-locals.el file which sets indent-tabs-mode appropriately?

from ws-butler.

@npostavs This wouldn't work with smart-tabs-mode at all. Ws-butler is currently completely incompatible with it. It used to work well.

from ws-butler.

This issue is fixed by my pull request #28. You can also fix it using my comment above in the meantime.

from ws-butler.