makecldf fails about abvd HOT 9 CLOSED

This is the new behavior!

from abvd.

It is there to catch explicitly these errors.

from abvd.

Go to line 222 in pylexibank/providers/abvd.py and change add_lexemes to add_forms_from_value.

First fix, as add_lexemes is deprecated.

from abvd.

Ah, and if you think that the ? is "normal" behavior, you can fix this also from within there, and add a line that checks if this form actually is a question makr or not. I.e., you check entry.name and see if it is a valid entry.

from abvd.

Ah, I get it now, sorry for not reading properly before. There is something wrong, I guess, as the entry should not pass the clean_form command, which is called after splitting it, and yields an empty form, which is then NOT passed to add_form. And clean_form reacts per default specifically on ? as a character here.

from abvd.

So the fix we need is in pylexibank code, dataset.py:

    def split_forms(self, item, value):
        if value in self.lexemes:  # pragma: no cover
            self.log.debug('overriding via lexemes.csv: %r -> %r' % (value, self.lexemes[value]))
        value = self.lexemes.get(value, value)
        return [self.clean_form(item, form)
                for form in split_text_with_context(value, separators='/,;')]

needs to be modified to:

    def split_forms(self, item, value):
        if value in self.lexemes:  # pragma: no cover
            self.log.debug('overriding via lexemes.csv: %r -> %r' % (value, self.lexemes[value]))
        value = self.lexemes.get(value, value)
        forms = [self.clean_form(item, form)
                for form in split_text_with_context(value, separators='/,;')]
        return [f for f in form if f]

Or similar. As this will only return forms that are not None, and this is crashing the code by now.

from abvd.

I'd say, this is a good example, why it was good to modify the behavior of the add_lexemes to being more transparent.

from abvd.

Just linked this as a bug in pylexibank.

from abvd.

Fixed.

from abvd.