Mixing Form inheritance with PHP inheritance about lexikformfilterbundle HOT 4 CLOSED

Maybe the problem comes from the bundle, maybe I missed something related to the changes made in SF2.1.

But after reading the discussion on your pull request on Symfony, maybe I should swap the Form inheritance and the PHP inheritance. I mean, all filter types should extend a AbstractFilterType class (which extends AbstractType). AbstractFilterType would be used to define the apply_filter option. And the getParent method would return the parent symfony type name instead of 'filter'.

So the ChoiceFilterType would be like this:

<?php
class ChoiceFilterType extends AbstractFilterType implements FilterTypeInterface
{
    /**
     * {@inheritdoc}
     */
    public function getParent()
    {
        return 'choice';
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'filter_choice';
    }

    /**
     * {@inheritdoc}
     */
    public function getTransformerId()
    {
        return 'lexik_form_filter.transformer.default';
    }

    /**
     * {@inheritdoc}
     */
    public function applyFilter(QueryBuilder $queryBuilder, Expr $expr, $field, array $values)
    {
        if (!empty($values['value'])) {
            $queryBuilder->andWhere($expr->eq($field, ':value'))
                         ->setParameter('value', $values['value']);
        }
    }
}

And methods from FilterTypeInterface could also be define in AbstractFilterType.

from lexikformfilterbundle.

@cedric-g yes, swapping Form and PHP inheritances seems like most sensible way out of this situation.
If you want, I can do it myself and test out on my 2.1 project, if it works then I'll submit a PR?

from lexikformfilterbundle.

Yes if you have some time you can do a PR. I should have some free time at the end of next week so I will be able to work on the bundle =)

from lexikformfilterbundle.

Done in above PR, closing

from lexikformfilterbundle.