embed filter not working for one to many relations ? about lexikformfilterbundle HOT 10 CLOSED

Hi :) I never get this this kind of error by embedding filters, but mainly because I never use any data_class in form types dedicated to filter I guess ^^. I will try to reproduce it if I find a bit of free time tomorrow.

from lexikformfilterbundle.

Ok, thanks. If you can't reproduce it you can ask me for an example.

from lexikformfilterbundle.

Can you show me an example where setXxxx is called ? I my case the addXxxx() method is called, so maybe I have made something a bit diferrent than you.

from lexikformfilterbundle.

Was on holiday, sorry. I'll try to provide you with a small example next week, ping me if I don't.

from lexikformfilterbundle.

I create a project with the issue here. You need a pg database for it to work. Tell me if you face any issues with it. The homepage should display a filter form with one field, and submitting it should give you the error message.

from lexikformfilterbundle.

I just created a filter_collection branch in which I added a new CollectionAdapterFilterType. This type is used to "simulate" a collection with always one element to keep value to filter.

So the code would looks like:

In FilmType the identifiers field is now a filter_collection_adapter type. The addShared method previously defined in LmcCodeFilterType is now passed as an option of filter_collection_adapter.

class FilmType extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder->add('identifiers', 'filter_collection_adapter', array(
            'type'         => new LmcCodeFilterType(),
            'default_data' => new ArrayCollection(), // just to initialize the collection with a valid value
            'add_shared'   => function (FilterBuilderExecuterInterface $qbe) {
                $closure = function(QueryBuilder $filterBuilder, $alias, $joinAlias, Expr $expr) {
                    $filterBuilder->innerJoin($alias . '.identifiers', 'i')
                          ->innerJoin('i.type', 't')
                           ->andWhere("t.name = 'LMC'");
                };

                $qbe->addOnce($qbe->getAlias().'.identifiers', 'i', $closure);
            },
        )) ;
    }

    public function getName()
    {
        return 'uc_legalbundle_filter_filmtype';
    }

    public function setDefaultOptions(OptionsResolverInterface $resolver)
    {
        $resolver->setDefaults(array(
            'data_class'        => 'Uc\LegalBundle\Entity\Film',
            'csrf_protection'   => false,
            'validation_groups' => array('filtering')
        ));
    }
}

And in the LmcCodeFilterType you do'nt need anymore to implements FilterTypeSharedableInterface.

class LmcCodeFilterType extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
            ->add('identifier', 'filter_text', array(
                'condition_pattern' => FilterOperands::STRING_STARTS,
                'label'    => false,
                'required' => false))
        ;
    }

    public function getName()
    {
        return 'uc_legalbundle_filter_lmc_code_type';
    }

    public function setDefaultOptions(OptionsResolverInterface $resolver)
    {
        $resolver->setDefaults(array(
            'data_class'        => 'Uc\LegalBundle\Entity\FilmIdentifier',
            'csrf_protection'   => false,
            'validation_groups' => array('filtering')
        ));
    }
}

What do you think about this implementation of managing collection ? does it work fine in your case ?

from lexikformfilterbundle.

I'll test that and will have a more thorough look later (probably this evening), but this looks good, thanks!

from lexikformfilterbundle.

I tested it, it works fine : there is no error and the produced SQL is fine (at least for the count query)

SELECT 
  COUNT(*) AS dctrn_count 
FROM 
  (
    SELECT 
      DISTINCT id0 
    FROM 
      (
        SELECT 
          f0_.id AS id0 
        FROM 
          film f0_ 
          INNER JOIN filmidentifier f1_ ON f0_.id = f1_.film_id 
          INNER JOIN filmidentifiertype f2_ ON f1_.type_id = f2_.id 
        WHERE 
          f2_.name = 'LMC' 
          AND LOWER(f1_.identifier) LIKE '12%'
      ) dctrn_result
  ) dctrn_table

I think this implementation might be better, because one probably wants to get different closures when filtering from different relations : they'll probably use a different join.

from lexikformfilterbundle.

I don't know if you still use the filter_collection branch but I will remove it, this feature is in the master branch since the version 2.1.

from lexikformfilterbundle.

Ok, go ahead, I'm apparently not using it.

from lexikformfilterbundle.