Symbolic Toolbox Dependency about libdirectional HOT 5 CLOSED

I see, that there is a dependency missing. The symbolic computations are different for each number of dimensions. Would you recommend adding it for a limited number of examples, i.e. d = 1,...12?

from libdirectional.

in lib\util\compileUtil, the generateSymbolic function is called for d = 2:6. I haven't gotten as far as using the the library, so I don't know how the symbolic results get used down the road. If the Symbolic Toolbox is only necessary during compile time to generate these files, then I would say to just generate the results as a static file for d = 2:6 and include that in the repository. If instead the library requires functions that only exist in the Symbolic Toolbox (for instance, the Riemann Zeta function does not have a purely numerical analog in the base MATLAB installation), then the project description should be updated to list the Symbolic Toolbox as a prerequisite dependency.

from libdirectional.

Ok, I think I generate the files and add them to the repository. I would then change the lines https://github.com/libDirectional/libDirectional/blob/master/lib/util/compileUtil.m#L50 to only generate more files, if the desired file is missing.

I would like to avoid enforcing the Symbolic Toolbox since most users may not need the normalization constant of the complex Bingham distribution anyway.

from libdirectional.

I now added a pull request for the generated files. Until it is merged, you can take the files from the pull request.

from libdirectional.

The pull request is merged now. I have also added the recommended toolboxes to the readme file.

from libdirectional.