Comments (2)
kleisauke
commented on May 21, 2024
I tried to remove that mutex on this branch, but it seems that LCMS still has a thread-safety issue regarding gmtime.
https://github.com/mm2/Little-CMS/blob/807809d7dd9b09c0380b71d5d5ebee3c1439ca99/src/cmsio0.c#L503-L504
TSAN results
Tested branch: main...kleisauke:remove-lcms-mutex
Run with:
$ BUILD_DIR=build_tsan CC=clang-12 CXX=clang++-12 SKIP_TEST=1 ./ci.sh tsan -DJPEGXL_ENABLE_SKCMS=OFF
$ ./build_tsan/lib/tests/passes_testCommit kleisauke@28c3009:
ThreadSanitizer: reported 8 warnings
(see tsan-lcms2.10.log for more details)
Commit kleisauke@e1a97c9:
ThreadSanitizer: reported 2 warnings
(see tsan-lcms2.12.log for more details)
Attachments:
tsan-lcms2.10.log
tsan-lcms2.12.log
from libjxl.
kleisauke
commented on May 21, 2024
A pull request has been made to fix the gmtime issue at mm2/Little-CMS#263.
from libjxl.
Related Issues (20)
- How to set JxlPixelFormat to BGR? HOT 3
- Tools report "Failed to decode image" for JPEG but still produces a score based on system libjpeg decoder
- "Illegal instruction (core dumped)" when encoding GIF to lossy JXL with effort 8 and 9
- cjxl fails with "JxlEncoderAddJPEGFrame() failed" for a valid JFIF file HOT 2
- Compression with --resampling=2 dramattically slower than other values
- What exactly resampling does? HOT 4
- libjxl should generate ICC profiles that use CICP tag when appropriate HOT 3
- Different defaults for SSIMULACRA2 and Butteraugli between APIs and executables HOT 4
- cjxl not properly converting the ICC profiles of some JPGs or djxl not properly decoding the converted JXLs with ICC profile back to JPG HOT 4
- The -p option (progressive) with jpg input files results in error and no image being put out, even when it is just on its own without any other options. HOT 3
- Pixel-to-jpeg is faster than Jpeg reconstruction? HOT 2
- cant open in photoshop HOT 3
- Wasm performance is much worse HOT 14
- cjpegli fails with nondescript error message if input PNG contains alpha HOT 2
- Utilities do not output useful debug and error messages, even with multiple `-v` arguments HOT 2
- Losslessly recompressing JXL turns enum tags into ICC profiles HOT 4
- Trouble linking wasm_demo with jpeg encoder HOT 5
- GitLab's wg1/jpeg-xl is not mirroring recent commits, out-of-date for several months HOT 2
- a recent commit breaks it building with MABS (build system for FFmpeg) HOT 3
- Issues with building and testing in mac OS. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libjxl.