Comments (10)
I just threw out the function. So how does it look, can you pull it and try again?
Failed to link:
FAILED: lava-triangle.exe
cmd.exe /C "cd . && C:\msys64\mingw64\bin\c++.exe -O3 -DNDEBUG /SUBSYSTEM:WINDOWS /ENTRY:mainCRTStartup -latomic CMakeFiles/lava-triangle.dir/liblava-demo/triangle.cpp.obj -o lava-triangle.exe -Wl,--out-implib,liblava-triangle.dll.a -Wl,--major-image-version,0,--minor-image-version,0 liblava.app.a liblava.block.a liblava.frame.a _deps/glfw-build/src/libglfw3.a liblava.asset.a liblava.resource.a liblava.base.a liblava.util.a _deps/spdlog-build/libspdlog.a liblava.file.a liblava.core.a _deps/physfs-build/libphysfs.a -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 && cd ."
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find /SUBSYSTEM:WINDOWS: No such file or directory
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find /ENTRY:mainCRTStartup: No such file or directory
collect2.exe: error: ld returned 1 exit status
[160/654] Building CXX object _deps/spirv-tools-build/source/CMakeFiles/SPIRV-Tools-shared.dir/diagnostic.cpp.obj
[161/654] Building CXX object _deps/spirv-tools-build/source/CMakeFiles/SPIRV-Tools-shared.dir/disassemble.cpp.obj
[162/654] Building CXX object _deps/spirv-tools-build/source/CMakeFiles/SPIRV-Tools-shared.dir/binary.cpp.obj
[163/654] Building CXX object CMakeFiles/template.dir/src/main.cpp.obj
[164/654] Building CXX object CMakeFiles/lava-light.dir/liblava-demo/light.cpp.obj
ninja: build stopped: subcommand failed.
from liblava.
Ok, now I made a small adjustment for this. Unfortunately I don't have much time for this right now, so I am very glad you're looking into this. 🤞
Confirmed it's building fine now. Thank you.
from liblava.
Hello, Thanks for your contribution.
Can you provide more information because latest GH Actions show that it builds properly.
Such as system info, configuration, logs, outputs...
from liblava.
I notice it's about MSYS2 MINGW64, it's not in the focus, but more information on what the build fails on would help.
from liblava.
$ ninja
[1/654] Building CXX object CMakeFiles/lava.util.dir/empty.cpp.obj
[2/654] Building CXX object CMakeFiles/lava.core.dir/empty.cpp.obj
[3/654] Linking CXX static library liblava.core.a
[4/654] Linking CXX static library liblava.util.a
[5/654] Building CXX object CMakeFiles/lava.file.dir/liblava/file/file.cpp.obj
FAILED: CMakeFiles/lava.file.dir/liblava/file/file.cpp.obj
C:\msys64\mingw64\bin\c++.exe -IC:/msys64/home/Administrator/liblava/build/_deps/physfs-src/src -IC:/msys64/home/Administrator/liblava/build/_deps/json-src/single_include -IC:/msys64/home/Administrator/liblava -O3 -DNDEBUG -std=gnu++23 -Wno-psabi -MD -MT CMakeFiles/lava.file.dir/liblava/file/file.cpp.obj -MF CMakeFiles\lava.file.dir\liblava\file\file.cpp.obj.d -o CMakeFiles/lava.file.dir/liblava/file/file.cpp.obj -c C:/msys64/home/Administrator/liblava/liblava/file/file.cpp
In file included from C:/msys64/home/Administrator/liblava/liblava/file/file.hpp:11,
from C:/msys64/home/Administrator/liblava/liblava/file/file.cpp:8:
C:/msys64/home/Administrator/liblava/liblava/core/data.hpp: In function 'char* lava::human_readable(size_t)':
C:/msys64/home/Administrator/liblava/liblava/core/data.hpp:338:12: error: 'strndup' was not declared in this scope; did you mean 'strdup'?
338 | return strndup(buf, buffer_size);
| ^~~~~~~
| strdup
[6/654] Building CXX object CMakeFiles/lava.file.dir/liblava/file/file_utils.cpp.obj
FAILED: CMakeFiles/lava.file.dir/liblava/file/file_utils.cpp.obj
C:\msys64\mingw64\bin\c++.exe -IC:/msys64/home/Administrator/liblava/build/_deps/physfs-src/src -IC:/msys64/home/Administrator/liblava/build/_deps/json-src/single_include -IC:/msys64/home/Administrator/liblava -O3 -DNDEBUG -std=gnu++23 -Wno-psabi -MD -MT CMakeFiles/lava.file.dir/liblava/file/file_utils.cpp.obj -MF CMakeFiles\lava.file.dir\liblava\file\file_utils.cpp.obj.d -o CMakeFiles/lava.file.dir/liblava/file/file_utils.cpp.obj -c C:/msys64/home/Administrator/liblava/liblava/file/file_utils.cpp
In file included from C:/msys64/home/Administrator/liblava/liblava/file/file_utils.hpp:10,
from C:/msys64/home/Administrator/liblava/liblava/file/file_utils.cpp:8:
C:/msys64/home/Administrator/liblava/liblava/core/data.hpp: In function 'char* lava::human_readable(size_t)':
C:/msys64/home/Administrator/liblava/liblava/core/data.hpp:338:12: error: 'strndup' was not declared in this scope; did you mean 'strdup'?
338 | return strndup(buf, buffer_size);
| ^~~~~~~
| strdup
[7/654] Building CXX object CMakeFiles/lava.base.dir/liblava/base/debug_utils.cpp.obj
[8/654] Building CXX object CMakeFiles/lava.file.dir/liblava/file/file_system.cpp.obj
[9/654] Building CXX object CMakeFiles/lava.file.dir/liblava/file/json_file.cpp.obj
FAILED: CMakeFiles/lava.file.dir/liblava/file/json_file.cpp.obj
C:\msys64\mingw64\bin\c++.exe -IC:/msys64/home/Administrator/liblava/build/_deps/physfs-src/src -IC:/msys64/home/Administrator/liblava/build/_deps/json-src/single_include -IC:/msys64/home/Administrator/liblava -O3 -DNDEBUG -std=gnu++23 -Wno-psabi -MD -MT CMakeFiles/lava.file.dir/liblava/file/json_file.cpp.obj -MF CMakeFiles\lava.file.dir\liblava\file\json_file.cpp.obj.d -o CMakeFiles/lava.file.dir/liblava/file/json_file.cpp.obj -c C:/msys64/home/Administrator/liblava/liblava/file/json_file.cpp
In file included from C:/msys64/home/Administrator/liblava/liblava/file/file.hpp:11,
from C:/msys64/home/Administrator/liblava/liblava/file/json_file.cpp:10:
C:/msys64/home/Administrator/liblava/liblava/core/data.hpp: In function 'char* lava::human_readable(size_t)':
C:/msys64/home/Administrator/liblava/liblava/core/data.hpp:338:12: error: 'strndup' was not declared in this scope; did you mean 'strdup'?
338 | return strndup(buf, buffer_size);
| ^~~~~~~
| strdup
[10/654] Building CXX object CMakeFiles/lava.base.dir/liblava/base/base.cpp.obj
ninja: build stopped: subcommand failed.
from liblava.
Thanks for the additional information. The problem seems to be obvious 👀
from liblava.
I just threw out the function. So how does it look, can you pull it and try again?
from liblava.
It's mixing MSVC switches with GCC switches. There must be errors on one of the CMakeLists.txt files.
from liblava.
Ok, now I made a small adjustment for this.
Unfortunately I don't have much time for this right now, so I am very glad you're looking into this. 🤞
from liblava.
Great that it worked out now. Thanks again 🤠
from liblava.
Related Issues (20)
- Queue creation improvements HOT 7
- Independent Project Build Fails - freetype not found HOT 2
- Install Instructions are Incorrect HOT 1
- Optional Dependencies HOT 2
- FBX Loading HOT 4
- HLSL Examples HOT 1
- RAII Abstractions HOT 1
- Latest release can not be built from Release downloads HOT 1
- Single validation error, not critical Linux Nvidia HOT 1
- Outputting fps to a text file? HOT 10
- PresentMon-like frametime logging HOT 2
- Request for compute example HOT 1
- Request for imgui docking HOT 2
- Does cmake ver need to be that high? Raspberry OS on 3.18 HOT 5
- How do I set up a cmake project? HOT 3
- Why can't I see Shader edits reflected in the program? HOT 2
- Add support to supply semaphores to renderer HOT 1
- Unable to take screenshots (how to best extend create methods) HOT 2
- Resize causes crash on Linux (tested with AMD gpu)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from liblava.