Giter VIP home page Giter VIP logo

Comments (10)

willscott avatar willscott commented on June 29, 2024

Yes - PRs welcome!

I wonder if Available is used anywhere? code search doesn't surface any obvious uses of it, so it may just be a left over remnant.

from go-reuseport.

g41797 avatar g41797 commented on June 29, 2024

I'd like to create N udp servers for the same port
Because on windows this functionality does not exist I should to call Available
in order to write portable code
Looks like Available will call control.available()
Also looks strange that for reuseaddr and reuseport returns 1 bool
your turn

from go-reuseport.

marten-seemann avatar marten-seemann commented on June 29, 2024

I wonder if Available is used anywhere? code search doesn't surface any obvious uses of it, so it may just be a left over remnant.

It is here: https://github.com/libp2p/go-libp2p/blob/4e2a16dd3f4f980bf9429572b3d2aed885594ec4/p2p/net/reuseport/listen.go#L46-L48

from go-reuseport.

g41797 avatar g41797 commented on June 29, 2024
  • leave Available as-is and add AvailReuseAddr & AvailReusePort or
  • func Available() (reuseaddr, reuseport bool)

btw what is the reason to require go 1.20?

from go-reuseport.

marten-seemann avatar marten-seemann commented on June 29, 2024

btw what is the reason to require go 1.20?

It's our release policy to support the two most recent Go releases.

  • leave Available as-is and add AvailReuseAddr & AvailReusePort or
  • func Available() (reuseaddr, reuseport bool)

What's the use case for splitting it into two?

from go-reuseport.

g41797 avatar g41797 commented on June 29, 2024

so something like:

// Available returns whether or not SO_REUSEADDR and SO_REUSEPORT are available in the OS.
func Available() (reuseaddr, reuseport bool) {
	return available()
}

from go-reuseport.

marten-seemann avatar marten-seemann commented on June 29, 2024

Again, what's the use case? What problem are you trying to solve?

from go-reuseport.

g41797 avatar g41797 commented on June 29, 2024

because SO_REUSEADDR is not enough:
"..traditional SO_REUSEADDR socket option already allows multiple UDP sockets to be bound to, and accept datagrams on, the same UDP port. However, by contrast with SO_REUSEPORT, SO_REUSEADDR does not prevent port hijacking and does not distribute datagrams evenly across the receiving threads" The SO_REUSEPORT socket option

from go-reuseport.

marten-seemann avatar marten-seemann commented on June 29, 2024

That's not what we're using reuseport though. We only use it for TCP, to be able to run a listener and outgoing connections on the same port. I don't think we should get into the specifics of SO_REUSEPORT and SO_REUSEADDR, as they're highly platform specific.

from go-reuseport.

g41797 avatar g41797 commented on June 29, 2024

no problem
you got star and new fork

from go-reuseport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.