Giter VIP home page Giter VIP logo

Comments (4)

bentiss avatar bentiss commented on August 20, 2024

I am fine with that. The problem I see is that github is not that convenient to add the sign-off-by after the pull request has been sent unless we re-write the patches.
So if we want to keep external contributors, it should not be a hard requirement.

However, I still like the signed-off-by, it help keeping tracks of who wrote which code, so I will definitively encourage people to use it and I will personally use it.

from libratbag.

whot avatar whot commented on August 20, 2024

well, the 'easy' way would be to pull it locally, then rebase/rewrite the commits and push to master. which is what we're doing wherever we don't use github's pull clickyness.

if we keep it, we should document what it means though :) even if it is just a link to the kernel doc

from libratbag.

phomes avatar phomes commented on August 20, 2024

I keep forgetting s-o-b - sorry. The other projects I work on typically do not use it so I forget.

from libratbag.

whot avatar whot commented on August 20, 2024

closing because there isn't much more to discuss. We encourage the s-o-b and may require it for some things (e.g. device drivers where the legal situation could be hairy) but we'll be lenient where we can be.

from libratbag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.