Comments (4)
I am fine with that. The problem I see is that github is not that convenient to add the sign-off-by after the pull request has been sent unless we re-write the patches.
So if we want to keep external contributors, it should not be a hard requirement.
However, I still like the signed-off-by, it help keeping tracks of who wrote which code, so I will definitively encourage people to use it and I will personally use it.
from libratbag.
well, the 'easy' way would be to pull it locally, then rebase/rewrite the commits and push to master. which is what we're doing wherever we don't use github's pull clickyness.
if we keep it, we should document what it means though :) even if it is just a link to the kernel doc
from libratbag.
I keep forgetting s-o-b - sorry. The other projects I work on typically do not use it so I forget.
from libratbag.
closing because there isn't much more to discuss. We encourage the s-o-b and may require it for some things (e.g. device drivers where the legal situation could be hairy) but we'll be lenient where we can be.
from libratbag.
Related Issues (20)
- G915 TKL and Superlight Wireless Pro Mouse not detecting HOT 1
- Add a tag HOT 1
- Is it possible to update firmware on any device using Libratbag HOT 1
- "Python dependency not found" It Says HOT 2
- Redragon M913 HOT 2
- How possible to release a new build for Ubuntu 22.04? Thanks! HOT 1
- Make the Adding a device wiki page more prominent
- Does this use the HID API of the kernel or what? HOT 3
- udev rule stop working HOT 1
- SteelSeries SteelSeries Prime support (usb:1038:182e) HOT 1
- Logitech G604 has incorrect active profile HOT 3
- Trust GXT 144 Rexx vertical mouse support (usb:145f:026d)
- SINOWEALTH INVAR 258a:0027 can be configured after editing device file
- Logitech SmartShift and thumb wheel configuration support
- ratbagctl can't see ratbagd running
- how do i clear a macro HOT 1
- Permission denied to run ratbagd, even when running it as root user HOT 2
- Logitech G Pro LED options do not work HOT 2
- Add support for the Roccat Burst Pro Air HOT 4
- MX master 3S support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libratbag.