Giter VIP home page Giter VIP logo

Comments (2)

Bnyro avatar Bnyro commented on June 9, 2024 2

Thanks to ExoPlayer, this change costed me an hour of reverse engineering their code, because they just randomly add callbacks to the player that can't be removed, so that implementing our own functionality is nearly impossible for the condition of whether the player should seek to the scrubbed position or not.

TL;DR: We now use a hacky solution that's anything but clean because ExoPlayer's API is just garbage, but it works now...

from libretube.

Bnyro avatar Bnyro commented on June 9, 2024

It's still debatable if the current behavior is better than your suggestion, I've just implemented it in a way that I personally feel most comfortable with (scrubbing and releasing it at the top of the screen). I'm open for other suggestions though, I just thought that swiping down can be triggered by accident too easily.

from libretube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.