Comments (2)
Thanks to ExoPlayer, this change costed me an hour of reverse engineering their code, because they just randomly add callbacks to the player that can't be removed, so that implementing our own functionality is nearly impossible for the condition of whether the player should seek to the scrubbed position or not.
TL;DR: We now use a hacky solution that's anything but clean because ExoPlayer's API is just garbage, but it works now...
from libretube.
It's still debatable if the current behavior is better than your suggestion, I've just implemented it in a way that I personally feel most comfortable with (scrubbing and releasing it at the top of the screen). I'm open for other suggestions though, I just thought that swiping down can be triggered by accident too easily.
from libretube.
Related Issues (20)
- Inconsistent Android status bar label color HOT 3
- External Download app advanced option
- Some channels does not show channel banner, profile, subscriber count HOT 1
- Option to hide live streams in feed HOT 3
- Pausing a video in picture-in-picture mode crashes LibreTube HOT 3
- Skip back button skips forward in picture-in-picture mode HOT 1
- Back key does not work while click search option in the Library Watch history page
- fix certain videos timestamps not showing in chapters list HOT 1
- Piped proxy quick toggle HOT 1
- Option to disable proxy for downloads only HOT 3
- Pause/Play in media notification turns into replay HOT 1
- App loading only subscriptions videos newer than a month HOT 5
- Material You Dynamic Theme does not work
- Notification playback controls don't work on Android 10 HOT 3
- Nightly: Going back to previous activity causes crash
- App Crashes When Refreshing Channel Page or Toggling Search Bar HOT 1
- is it possible to integrate the instances that Tubular/newpipe use to libretube HOT 2
- Latest missing on F-Droid
- SponsorBlock for Audio player
- Got error : "sign-in to confirm you are not a robot" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libretube.