Comments (11)
@serverfire : we tested and reviewed the first version you pushed.
Based on the initial specs, we noticed the following missing feature:
If credentials are not stored in session or local storage (depending on wether or not the user checked the checkbox "remember me")
With the current code, the credentials are always stored in local storage. They should be stored in session storage if user did not check the box
from javascript.
While we don't have a server side application we don't have session storage.
I can store them in cookies if you want. Or we can check expiration manually.
from javascript.
While we don't have a server side application we don't have session storage.
I am not sure I understand what you mean. Are you using http://localhost ... or file:// to test?
from javascript.
In addition to the missing feature mentioned above, please keep the implicit coding conventions that have been followed in this project:
- the assets/libs directory is for external libraries. Our own js files should be in assets/js
- .hbs files should not contain javascript code, such code should be in js files
from javascript.
I mean server side apps like php
can store user information in session(somewhere in server).
Alright We'll follow these steps.
from javascript.
Do you know that the 'Bucket' is a required param in AWS? We are not asking it.
For now, all user directories are stored in bucket "librelio-europe"
from javascript.
@richardruiter I will be able to test your commit at about 1:00PM.
In the meantime, when clicking on Log In in the previous version, nothing happened during a few seconds (time for js to check credentials). If you have suggestions to change the UI in some way after the user has clicked, maybe using one of the libraries in the project, this will be appreciated.
from javascript.
@libreliodev i might be delayed a bit, because iยดm having some trouble getting the AWS authentication to work... just to let you know.
from javascript.
@richardruiter thanks for the info. Why don't you use @serverfire's code? It's still incomplete, but AWS authentication works. Be aware that you need to add a "/" after the user directory name.
from javascript.
@libreliodev You can see "remember me" is now supported via sessionStorage.
from javascript.
Successfully tested.
from javascript.
Related Issues (20)
- Implement Pivottable.js in reader and admin HOT 2
- Implement server side authorization for Google Analytics HOT 7
- In Firefox, in admin, localized version is sometimes not displayed HOT 13
- In admin, filters do no work when using pivottable.js HOT 3
- Increase size of covers to 600 px
- When editing pdfs, include link number on page for iOS HOT 2
- Make sure the www site is localizable HOT 1
- Remove interstitials menu HOT 1
- Implement submenus for analytics HOT 1
- Add forms menu in left bar HOT 1
- Implement markdown editor HOT 1
- Compile error while ussing $ grunt. HOT 3
- Debian Installation
- The command open index.html HOT 6
- In backoffice, don't allow to activate folder with no file
- I can't compile javascript version
- Admin console login HOT 2
- how to linking admin console with aws account HOT 3
- Aws admin console login
- Not able to save anything in the Librelio admin console GUI HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from javascript.