Giter VIP home page Giter VIP logo

Comments (11)

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire : we tested and reviewed the first version you pushed.

Based on the initial specs, we noticed the following missing feature:

If credentials are not stored in session or local storage (depending on wether or not the user checked the checkbox "remember me")

With the current code, the credentials are always stored in local storage. They should be stored in session storage if user did not check the box

cc @richardruiter

from javascript.

serverfire avatar serverfire commented on August 23, 2024

While we don't have a server side application we don't have session storage.
I can store them in cookies if you want. Or we can check expiration manually.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

While we don't have a server side application we don't have session storage.

I am not sure I understand what you mean. Are you using http://localhost ... or file:// to test?

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

In addition to the missing feature mentioned above, please keep the implicit coding conventions that have been followed in this project:

  • the assets/libs directory is for external libraries. Our own js files should be in assets/js
  • .hbs files should not contain javascript code, such code should be in js files

from javascript.

serverfire avatar serverfire commented on August 23, 2024

I mean server side apps like php can store user information in session(somewhere in server).
Alright We'll follow these steps.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@richardruiter

Do you know that the 'Bucket' is a required param in AWS? We are not asking it.

For now, all user directories are stored in bucket "librelio-europe"

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@richardruiter I will be able to test your commit at about 1:00PM.

In the meantime, when clicking on Log In in the previous version, nothing happened during a few seconds (time for js to check credentials). If you have suggestions to change the UI in some way after the user has clicked, maybe using one of the libraries in the project, this will be appreciated.

from javascript.

richardruiter avatar richardruiter commented on August 23, 2024

@libreliodev i might be delayed a bit, because iยดm having some trouble getting the AWS authentication to work... just to let you know.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@richardruiter thanks for the info. Why don't you use @serverfire's code? It's still incomplete, but AWS authentication works. Be aware that you need to add a "/" after the user directory name.

from javascript.

serverfire avatar serverfire commented on August 23, 2024

@libreliodev You can see "remember me" is now supported via sessionStorage.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

Successfully tested.

from javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.