Add svg editing page based on SVG-edit about javascript HOT 17 CLOSED

@libreliodev There is an issue about listing publications svg files. It's about knowing whether they are free or paid.
There is two method to do that.

1. Listing all publication with a request and check every publication whether it has paid or not. In this method number of request increases proportional to number of publications. In long run this method is better than next one.
2. List all files within an app. We have all files then and we can check their type. But it is very inefficient. Good part is we can find out list with one or few requests.

Both of these method are not efficient methods. I suggest we should list all publications in one file and save everything we need to know about them in it. a plist file would be fine.

from javascript.

@serverfire I don't understand the issue here. We should use the same method to list publications as in #8. Factorizing the code should be a good idea.

from javascript.

@libreliodev There is a difference between this one and #8. When we list publications in there we didn't need to know their type(free/paid) so it's easy.
But in here we need to know what's their type.("If there are both a paid and free version of a publication, display both specifying (free) or (paid)")

from javascript.

@serverfire OK, got it.

Both of these method are not efficient methods. I suggest we should list all publications in one file and save everything we need to know about them in it. a plist file would be fine.

I don't think this is a good idea, because it is also possible for your admin users to upload publications not using this console. So, it would be difficult to keep the extra plist file up to date.

1. Listing all publication with a request and check every publication whether it has paid or not. In this method number of request increases proportional to number of publications. In long run this method is better than next one.

I think this is the best option. I finally think we should not display immediately "free" or "paid". When a user selects one publication for opening, we should check wether there is both a paid and free version, and in this case display an additional dialog to ask which version should be opened.

from javascript.

@libreliodev Ok. That's a clever decision. I'll do it.

from javascript.

@libreliodev How we can know a publication is in svg format?
Do you mean i should check all uploaded file where are in svg format then add edit button next to it. Or there is a specific upload file for this?
ps. Publication image's extension is png. It was in spec.

from javascript.

@serverfire

How we can know a publication is in svg format?
Do you mean i should check all uploaded file where are in svg format then add edit button next to it. Or there is a specific upload file for this?

No,you should just check the main file (same name as folder, ending with a _ or not)

ps. Publication image's extension is png. It was in spec.

png is for the cover of the publication

from javascript.

@libreliodev Ok Thanks.

from javascript.

@libreliodev You can check this issue. Hopefully it's completed!

from javascript.

@serverfire There seems to have been a misunderstanding. A given publication can only be in one format. So, for example, publication eeeee, which is in pdf format, should not appear as editable with svg editor

from javascript.

@libreliodev Ok, But this will bring another issue. How can we find publication format. Until now it was .pdf
If you want to make it a variable. Quick fix is to save information about every publication in a specific file.

from javascript.

@serverfire Sorry for the late answer.

But this will bring another issue. How can we find publication format.

As a reminder, publication file has same name as containing folder. So, we just need to look for filenames starting with [user]/[app]/[publicationname]/[publicationname], and deduct the format.

If you want to make it a variable. Quick fix is to save information about every publication in a specific file.

This is not feasible. Again, some users can access directly thier S3 directory using FTP like software.

from javascript.

@libreliodev Alright. I should make some changes in publication implementation.

from javascript.

@libreliodev I've fixed the issue. Can you check it?

from javascript.

@serverfire

When click on the eeeee publication in SportGuide, I still have an "Edit SVG" button which should not be there.

from javascript.

@libreliodev publication files of eeeee are in svg format. That's why they're there.
I need more information to do something about it.

from javascript.

@serverfire
OK sorry. Successfully tested.

from javascript.