Giter VIP home page Giter VIP logo

Comments (22)

avinahum avatar avinahum commented on August 23, 2024

Do you really want to implement Plupload on this little modal window?

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@avinahum

Do you really want to implement Plupload on this little modal window?

We do need to implement multi file upload, because there are potentially multiple assets for a given publication. Plupload seems to be the best option, because it is already included in the project, but let us know if you have other suggestions.

Regarding the "little modal window", we are open to suggestions to improve the UI.

from javascript.

AlirezaAlgo avatar AlirezaAlgo commented on August 23, 2024

@libreliodev I've implemented issue #9 #11. Can you check it?

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire We have not tested completely because we have noticed new issues that seem to come from your latest commit and need to be fixed before: see #18 et #19

Regarding this issue, can you please improve the layout of the modal window?

  • title filed needs to be properly aligned
  • radio button paid/free looks strange

screen shot 2014-04-24 at 10 06 30

from javascript.

AlirezaAlgo avatar AlirezaAlgo commented on August 23, 2024

@libreliodev I think you didn't install the app correctly. Apparently bootstrap styling is gone.
Can you check it?

from javascript.

avinahum avatar avinahum commented on August 23, 2024

@serverfire i think it happened because of merging files process

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire

I think you didn't install the app correctly. Apparently bootstrap styling is gone. Can you check it?

The console does not report CSS or Javascript files missing. What do you think?

screen shot 2014-04-24 at 15 12 58

from javascript.

AlirezaAlgo avatar AlirezaAlgo commented on August 23, 2024

@libreliodev Apparently in your copy, You have extra libs which is not in repo. I think this is why we have different UI in app.
I've made a commit which removes extra files used in publication.html so now you should have same UI.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire

I am sorry, I still have a different UI, and I don't see Title and Subtitle anymore

screen shot 2014-04-24 at 17 12 06

from javascript.

AlirezaAlgo avatar AlirezaAlgo commented on August 23, 2024

@libreliodev I don't have this issue.
Obviously we don't have the same files. We have to option in here.

  1. you can get another clone from this repository.
  2. send your changes to repo.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire I don't think your options work, because the dist folder has been added to .gitignore, which means it's no longer updated in the repository. I have uploaded a compressed copy of my dist folder to the developer directory on the S3. Please let me know if it's OK for you to review it, or if you have other suggestions.

from javascript.

AlirezaAlgo avatar AlirezaAlgo commented on August 23, 2024

@libreliodev I don't think I've to do anything with dist directory.
When you clone the project you have to also install it.(includes calling grunt command which creates dist directory).
If you couldn't do it. I'll check that zip file.
let me know

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire

I don't think I've to do anything with dist directory.
When you clone the project you have to also install it.(includes calling grunt command which creates dist directory).

I don't understand what you mean here. Obviously, the problem is that the content of our dist directories (generated by Grunt, of course) differ, otherwise we would "have the same files".

We need to understand where the differences are, and where they come from. if you have suggestions to proceed differently, let me know.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire We have uploaded the latest build of the project in http://librelio-admin.s3.amazonaws.com

You can see by yourself that the styling in not correct. Can you please upload your own version there? Don't worry if you delete our own upload, it's not yet in production. We have given the required permissions to user "developer".

from javascript.

AlirezaAlgo avatar AlirezaAlgo commented on August 23, 2024

@libreliodev I get access denied error in http://librelio-admin.s3.amazonaws.com

Our dist directories differs because our src directories also differs. Every time we call grunt. Grunt will delete all files in diet and regenerates them from src dir.
You can check the difference with git command.
cd /path/to/libreliodev && git status

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire

Every time we call grunt. Grunt will delete all files in diet and regenerates them from src dir.
Our dist directories differs because our src directories also differs.

We are aware of all this, of course.

Here is a copy of what we get with git:

macep6:javascript xxxx$ git pull 
Already up-to-date.
macep6:javascript xxxx$ git status
On branch master
Your branch is ahead of 'origin/master' by 14 commits.
  (use "git push" to publish your local commits)

nothing to commit, working directory clean

The only differences we can have are in src/assets/submodule/ , because this directory is ignored in .gitignore.

I get access denied error in http://librelio-admin.s3.amazonaws.com

I double checked using your credentials, it works fine, you should be able to access this bucket.

from javascript.

AlirezaAlgo avatar AlirezaAlgo commented on August 23, 2024

@libreliodev How should i put credentials to that url?
Here is our copy and a tar file contains dist dir.
http://serverfire.net/project/hossien/libreliodevjs/dist/publications.html
http://serverfire.net/project/hossien/libreliodevjs/dist.tar.gz

from javascript.

AlirezaAlgo avatar AlirezaAlgo commented on August 23, 2024

@libreliodev Your status says that you've made 14 commits on and you didn't push it to github repo.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire

I tested the version on your server, using Safari and Explorer, and I still have the problem. See screenshot below.

screen shot 2014-04-26 at 10 42 40

Your status says that you've made 14 commits on and you didn't push it to github repo.

I know, but I don't think that's the point. I will push them when we've solved this issue.

from javascript.

AlirezaAlgo avatar AlirezaAlgo commented on August 23, 2024

@libreliodev I'm sorry about the delay.
I did found what was the reason of UI difference. It was because of screen size.
bootstrap have custom layout for different screen sizes and my browser was in small size this whole time. until i checked it on another computer.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

@serverfire No problem, thanks for the update.

from javascript.

libreliodev avatar libreliodev commented on August 23, 2024

Successfully tested

from javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.