Giter VIP home page Giter VIP logo

Comments (14)

jcupitt avatar jcupitt commented on June 9, 2024 1

OK, I made an enhancement issue. Thanks!

I'll close this one.

from libvips.

jcupitt avatar jcupitt commented on June 9, 2024

@kurtextrem added some useful notes here: lovell/sharp#4018

from libvips.

kurtextrem avatar kurtextrem commented on June 9, 2024

Worth noting Jpegli is included in the JXL repo: https://github.com/libjxl/libjxl/blob/main/lib/jpegli/README.md:

When building the parent libjxl project, two binaries, tools/cjpegli and tools/djpegli will be built, as well as a lib/jpegli/libjpeg.so.62.3.0 shared library that can be used as a drop-in replacement for the system library with the same name.

so it might not require extraordinary effort if the "just replace" method is picked (replacing the lib inside libvips), if I understand correctly? It might be valuable to keep mozjpeg around for comparison and upgrade compatibility reasons though (at least temporarily).

from libvips.

jcupitt avatar jcupitt commented on June 9, 2024

If it's just a question of dropping in a binary-compatible jpeg library, then this is really an enhancement for the various libvips build repos.

@kleisauke, shall I made an enhancement issue for the windows build system?

from libvips.

jcupitt avatar jcupitt commented on June 9, 2024

erickguan noted:

A few articles I skimmed through:

from libvips.

kurtextrem avatar kurtextrem commented on June 9, 2024

It looks like mozjpeg might still be worth keeping:

I also didn't test every chroma subsampling mode that mozjpeg has to offer, and allowed mozjpeg to subsample chroma automatically - this automatic selection gives it a theoretical advantage over each individual jpegli chroma subsampling mode, but wouldn't allow the encoder to display its breadth of competence like jpegli here. In the end, I wouldn't call this a loss for mozjpeg anyhow - it is clearly not obsolete in any case, and the only scenario in which it clearly lost was the first image test. The overall average & three image average results make a compelling case for mozjpeg overall.
(from https://giannirosato.com/blog/post/jpegli/)

jpegli appears to be better than mozjpeg at q80-100.

from libvips.

kleisauke avatar kleisauke commented on June 9, 2024

@kleisauke, shall I made an enhancement issue for the windows build system?

Sure, that would be great. I'll see if I could add a --with-jpegli build option during the weekend.

from libvips.

andrews05 avatar andrews05 commented on June 9, 2024

Will there need to be a new option to use the XYB colorspace?

from libvips.

jcupitt avatar jcupitt commented on June 9, 2024

I don't think so (but perhaps I'm wrong).

from libvips.

kurtextrem avatar kurtextrem commented on June 9, 2024

A small question for my understanding: so if jpegli is built and the jpeg libs are replaced at sys level during building of libvips (for linux), or built with --with-jpegli on windows, jpegli would be up and running for anything using libvips?

from libvips.

jcupitt avatar jcupitt commented on June 9, 2024

Yes, it aims to be a drop-in binary-compatible replacement.

It will only replace regular libjpeg for dynamically linked programs, of course. If you have a statically linked libjpeg in there it'll be harder to swap out.

from libvips.

alanorth avatar alanorth commented on June 9, 2024

FYI there is new discussion around this after Google did an introduction post about jpegli:

https://opensource.googleblog.com/2024/04/introducing-jpegli-new-jpeg-coding-library.html

What ended up happening with this issue? I'm confused with the discussion/issue split here in GitHub.

from libvips.

adityapatadia avatar adityapatadia commented on June 9, 2024

Yeah, I would like to know as well if this is going to be released anytime soon.

from libvips.

kurtextrem avatar kurtextrem commented on June 9, 2024

See above, while libvips itself (apart from the windows build) doesn't have a specific build option, you can replace the jpeg lib and then build libvips. #3872 (comment)

That's a bit cumbersome, so if you think a better way would be nice, maybe worth opening an issue?

from libvips.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.