Giter VIP home page Giter VIP logo

Comments (5)

jcupitt avatar jcupitt commented on July 19, 2024 2

I made #4005 for 8.15 -- it's a minimal PR that just changes the fallback and doesn't touch most of the code. Let's move any discussion there.

Let's use Kleis' much more comprehensive one for master.

I credited you in the changelog @Julianiolo, and thanks again for finding this terrible thing!

from libvips.

jcupitt avatar jcupitt commented on July 19, 2024 1

Hi @Julianiolo, this is a great find, this must have been causing rare problems on windows (I suppose?) since we switched to meson. I'll make a PR for these two issues.

from libvips.

jcupitt avatar jcupitt commented on July 19, 2024 1

Yup, our terrible home-made fallback pre-dates libvips being used in heavily threaded applications. The glib one is a great upgrade.

from libvips.

lovell avatar lovell commented on July 19, 2024

Could we switch to the glib-provided g_vsnprintf?

from libvips.

kleisauke avatar kleisauke commented on July 19, 2024

I just opened PR #4004 for this.

from libvips.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.