Giter VIP home page Giter VIP logo

Comments (4)

jcupitt avatar jcupitt commented on June 2, 2024

libvips also has adaptive convolution resample as well as fixed window interpolators -- it has two completely different paths for the two systems.

I think that comment went in in 2015 after we swapped some mails. You said that pillow-simd always used adaptive convolution, so I wanted to avoid penalising pillow-simd, and picked nearest.

Do you think Image.BILINEAR would be fairer?

from vips-bench.

homm avatar homm commented on June 2, 2024

libvips also has adaptive convolution resample as well as fixed window interpolators -- it has two completely different paths for the two systems.

Could you disclose why they are separated? If you have both, the good solution is to choose one of them internally based on scale factor, but do not let a user spoil the data. In my opinion, fixed window interpolation shouldn't be used for the shrinking at all, because even with scale factor from 0.5 to 1 the window width will be > 2.

Do you think Image.BILINEAR would be fairer?

Yes. To be honest, I also think that VIPS's method should be changed to adaptive convolution and OpenCV's method to INTER_AREA.

from vips-bench.

jcupitt avatar jcupitt commented on June 2, 2024

It's just historical: vips used to just have fixed-window interpolators, and the adaptive kernel stuff was added in 8.3 (I think).

I've swapped everything to adaptive, I think.

from vips-bench.

homm avatar homm commented on June 2, 2024

I don't think that reduce is actually adaptive:

Pillow:
_out pillow

im = im.resize(0.1, kernel='linear')
_out vips resize

im = im.reduce(1.0 / 0.1, 1.0 / 0.1, kernel='linear')
_out vips reduce

im = im.similarity(scale = 0.1, interpolate = pyvips.Interpolate.new("bilinear"))
_out vips similarity

from vips-bench.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.