Comments (1)
Here's some "analysis" / a workaround... 😅
--- a/ui/analyse/src/study/relay/relayLeaderboard.ts
+++ b/ui/analyse/src/study/relay/relayLeaderboard.ts
@@ -1,11 +1,23 @@
import { Redraw, VNode, looseH as h } from 'common/snabbdom';
import * as xhr from 'common/xhr';
import { spinnerVdom as spinner } from 'common/spinner';
-import { RelayPlayer, RoundId } from './interfaces';
-import { playerFed } from '../playerBars';
+import { RoundId } from './interfaces';
import { userTitle } from 'common/userLink';
-interface LeadPlayer extends RelayPlayer {
+interface LeadPlayer { // extends RelayPlayer !!! Conflicting "fed" field, 'string' from /broadcast/<id>/leaderboard vs 'Federation'
+
+ // Duplicate RelayPlayer ...
+ name: string;
+ rating?: number;
+ title?: string;
+ fideId?: number;
+ // ...
+
+ // Deviate from RelayPlayer ...
+ fed?: string;
+ // ...
+
+ // LeadPlayer
score: number;
played: number;
}
@@ -56,7 +68,7 @@ const renderPlayers = (players: LeadPlayer[]): VNode => {
'th',
player.fideId
? h('a', { attrs: { href: `/fide/${player.fideId}/redirect` } }, [
- player.fed && playerFed(player.fed),
+ player.fed && leadPlayerFedId(player.fed),
userTitle(player),
player.name,
])
@@ -70,3 +82,8 @@ const renderPlayers = (players: LeadPlayer[]): VNode => {
),
]);
};
+
+const leadPlayerFedId = (fedId: string) =>
+ h('img.mini-game__flag', {
+ attrs: { src: site.asset.url(`images/fide-fed/${fedId}.svg`), title: `Federation: ${fedId}` },
+ });
from lila.
Related Issues (20)
- Incomplete display of data at "get user public data" endpoint HOT 1
- dasher.toggle event not fired the first time the user menu is opened (only on mobile)
- Issue 14960 not fixed on mobile HOT 2
- let study admins invite more members
- Losing connection changes game timer HOT 1
- Home/End keys HOT 1
- Official blogs 404 with Kid mode
- Revert Annotator Test
- broken perf page
- modernize ui/learn HOT 1
- Broadcast: differentiate when you are not in an official movement HOT 1
- Wrong time bar when giving extra time
- "Learn from your mistakes" prefers worse move HOT 1
- /api/account - json object "perfs" now contains a json object "standard" among the perfomance types - possibly it shouldn't HOT 2
- Blog Search
- Was rematch offer sent or received
- Impossible to get 3 stars for problem 9 of castling in /learn HOT 2
- "Create Game" Rating range filter
- add Federation codes to FIDE Player IDs
- Display issue with small width and evaluation enabled
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lila.