Giter VIP home page Giter VIP logo

Comments (2)

Standard8 avatar Standard8 commented on August 22, 2024 1

The problem appears to be this bit of the code: https://github.com/search?q=repo%3Alieser%2Fdkim_verifier+tab.url%3F.startsWith%28%22chrome%3A%2F%2Fconversations%2F%22%29&type=code

I suspect this due to how the Thunderbird rework has changed all the tab processing - the tab no longer has a url field option, and so chrome://conversations can't be matched.

I'm not sure of an easy option of what to do there, except for maybe detecting if Conversations is installed/active and running it regardless.

from dkim_verifier.

lieser avatar lieser commented on August 22, 2024 1

Thanks for reporting the issue, this should be fixed now. If you want to try it out already you can use the following version:
[email protected]

@Standard8 You there correct about the problematic code.
I extended your proposed check a little to work with the case that a message is viewed in a tab or windows (in the classic view).

I noticed that if Conversations is installed browser.messageDisplay.onMessageDisplayed is not triggered even then viewing single messages in Thunderbird's 3pane tab. I guess this is something Conversations prevents?
This is nothing that interferes with my add-on, it actually means the check I do fo conversation there is not needed currently. I still decided to leave it in in case it changes in the future.

from dkim_verifier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.