Comments (3)
Hi! thanks for your contribution!, great first issue!
from lightning-thunder.
We love torch.compile and use it a lot, too, and when enabling it in thunder (and perhaps disabling other backends) we expect numbers to be in the same ballpark. Do try it out!
That said, PyTorch eager is a more stable anchor point for us (maybe like the Prototype Metre in olden times), so we think it is most useful to our measurement.
from lightning-thunder.
Thank you @bonlime, as @t-vi wrote our baseline is eager.
We are all about compounding the effect of multiple optimizations and have torch.compile in the mix.
In the case of the plot it was roughly equivalent to the first bar in that particular experiment, but again, we are not interested in a head to head comparison as it would be misleading with respect to the goals of the project.
from lightning-thunder.
Related Issues (20)
- Benchmark: Running benchmark_litgpt with `transformerengine` leads to `nullcontext` not defined.
- uniform_like: The function outputs different values when the input tensor is the same but `requires_grad` is True/False. HOT 2
- Add activation checkpointing to litGPT benchmarking script HOT 1
- utils.find_producer_symbols is too aggressive at collecting producer symbols not taking into account stop information HOT 1
- Add more nvFuser debug information HOT 4
- reenable apex backward / phantom grad tests without wrecking CI HOT 3
- Investigate GPU memory intense CI tests HOT 1
- Regression on thunder/benchmarks/targets.py HOT 1
- CSE pass should work on symbols with keyword arguments
- grad transform introduces reduction operation with NumberProxy in axes HOT 4
- No module named 'flax' when using thunder/benchmarks/benchmark_litgpt.py HOT 3
- Excessive caching for `torch.dtype` objects
- torch.Tensor.size is broken on main HOT 1
- Test failure in `test_transformer_engine_executor.py::test_te_linear_forward_backward` and others HOT 3
- Enable cuDNN executor by default HOT 3
- Likely memory fragmentation for larger models HOT 5
- Failure when using context manager HOT 1
- disabling implicit NumberProxy to Number translation.
- Broken CI tests for distrubuted HOT 1
- `CUDAGraphExecutor` - limited to static graphs only
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning-thunder.