Giter VIP home page Giter VIP logo

Comments (4)

kenny-evitt avatar kenny-evitt commented on June 3, 2024

@cldwalker I could really use 'wrap'. Let me know when you could go over this with me; at least a push in the right direction.

from paredit.

cldwalker avatar cldwalker commented on June 3, 2024

@kenny-evitt Unfortunately I don't know any of this code base. If you just want wrap fns to use, paredit-plus has them. If you want to add to this plugin that's also great. We may also want to consider adopting @rundis' https://github.com/rundis/parembrace at some point
@rundis Do you know what advantages and disadvantages parembrace has compared to this plugin?

from paredit.

rundis avatar rundis commented on June 3, 2024

From the top of my head;

Advantages in favour of parembrace

  • It's not far from being feature-complete compared to the emacs version. I'e supports much more of paredit than this plugin. it also support additional handy features
  • The code is more readable, maintainable and the ops are more composable
  • It uses rewrite-cljs so the codebase is smaller. And rewrite-cljs really knows how to parse, traverse and rewrite clojure/clojurescript/edn code.
  • It's better documented (not than paredit-plus, but the LT paredit that is) !

Disadvantages by using parembrace

  • It really only supports clojure/clojurescript/edn. It's biggest limitation (but also it's greatest advantage, working on clojure ast nodes through a zipper rather than all editor and text parsing/tokenization)
  • It's not as fast (but mostly fast enough)

@kenny-evitt I'm a little bit familiar with the code of this plugin, but really if we are to continue supporting a language neutral paredit, I think the code base needs a serious rewrite to make it maintainable.
From a personal perspective I don't really work on any other lisps so I'm not interested in putting effort into this plugin, my time would be betters spent improving parembrace.

I'd be more than happy to hand over ownership of parembrace to LT :-)

from paredit.

kenny-evitt avatar kenny-evitt commented on June 3, 2024

@cldwalker No worries. I'll put working on this plugin onto the 'maybe' list then. I'm not sure what's responsible for the feature, but I can wrap a selection if I make a 'regular selection' – it's just the Vim selections (and, therefore, the Vim navigation features) that don't work.

@rundis I'll have to play with parembrace now too. I've got a list with several of your plugins on it to get thru eventually.

Maybe we should just canonize paredit-plus as the 'official' paredit plugin. There haven't been any updates in a while, but there aren't really any major open issues either.

from paredit.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.