Comments (3)
If you enable this line, which sets the server error handler,
https://github.com/dlvenable/armeria-sample/blob/2bf911126d2610ab4284f0adbf177999e3ea59b3/src/main/java/io/venable/samples/armeria/request_timeout/RequestTimeoutExperiment.java#L60
408 is returned. Could you check that again, please? 🤔
from armeria.
@minwoox ,
Yes, I enabled that line and also added logging. I can see that it reaches the condition and returns the 408.
Ideally we would not be using a custom error handler to resolve this. It seems that the default error handler is not being used when the throttling strategy is enabled. Is that something you could do?
If we do have to enable a custom error handler, is there a way to get the default one so that we don't have to duplicate the conditions? It appears that the default error handler is package protected.
from armeria.
Ideally we would not be using a custom error handler to resolve this.
That is correct. 👍
It seems that the default error handler is not being used when the throttling strategy is enabled.
I'm not 100% sure but it seems like it's being used.
We haven't implemented returning 408 yet when the client doesn't set the request fully.
So I think the server returns 503 if you don't apply your custom error handler.
Let me ping you when #5579 is done so that you don't have to apply your own error handler. 😉
from armeria.
Related Issues (20)
- Provide a way to customize meters
- Add pendingResponses to ServerMetrics
- Add ServerBuilder.coroutinService as Kotlin extension method
- Test failure: `com.linecorp.armeria.common.ContextPushHookTest.shouldRunHooksWhenContextIsPushed()`
- Test failure: `com.linecorp.armeria.server.InvalidPathWithDataTest.invalidPath()` HOT 1
- Investigate if we can stop `ServiceRequestContextBuilder.build()` from scheduling an event loop task HOT 1
- Use `SELF` for Builder Self Type Parameter
- Test failure: `com.linecorp.armeria.server.Http1ServerDelayedCloseConnectionTest.shouldDelayDisconnectByServerSideIfClientDoesNotHandleConnectionClose()`
- Test failure: `com.linecorp.armeria.common.stream.InputStreamStreamMessageTest.thrownInputStream()` HOT 1
- Close a WebSocket when it is idle
- SslStoreProvider has been removed in spring boot 3.3.0, armeria webflux backward compatibility broken
- Consider setting minimum JDK version to 11 or 17 HOT 1
- Healthcheck service returning unhealthy between tests if service is reconfigured
- Suggest adding an example when armeria + spring is used for docs.
- Support for degraded health HOT 1
- `RetryingClient` gets deadlocked when a decorator returns a failed response.
- Let `GrpcService` specify a maximum bound for `grpc-timeout` HOT 6
- Consider dropping `:` from path pattern
- Set `RequestLog#content` for `AnnotatedService` if a pojo is requested/returned
- Provide an easy way for users to leave `ClientConnectionTimings` to logs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from armeria.