Giter VIP home page Giter VIP logo

Comments (5)

ikhoon avatar ikhoon commented on July 17, 2024

@ghkim3221 suggested an idea that filters out mirror_state.json from Watcher to mitigate the problem:

The issue might be hard to apply because many users already have their mirror_state.json in each repository. It may be a huge break.
As a simple workaround, how about not notifying Watchers if mirror_state.json is changed? More generally, we can introduce a filter to Watcher excluding files that trigger the notification.

from centraldogma.

minwoox avatar minwoox commented on July 17, 2024

FYI:
One of the reasons that we store mirror_state.json in the repository is to guarantee atomicity in a simple way.

from centraldogma.

0x1306e6d avatar 0x1306e6d commented on July 17, 2024

Thank you!!!
May I try to send a PR?

from centraldogma.

ikhoon avatar ikhoon commented on July 17, 2024

May I try to send a PR?

There is a dependency on this feature. If mirror_state.json is migrated to meta, the file name of mirror_state.json should be changed to <mirror_id>_mirror_state.json to avoid conflicts with other mirrors. As mirror_id is an optional value, we need to fill mirror_id for all mirror configurations first.

I was implementing #838 (review) but haven't finished yet.

@ghkim3221 suggested an idea that filters out mirror_state.json from Watcher to mitigate the problem:

What do you think of sending a PR for this first? Otherwise, would you wait until #838 is merged?

from centraldogma.

0x1306e6d avatar 0x1306e6d commented on July 17, 2024

Oh, I was being ambiguous.

What do you think of sending a PR for this first?

This is what I also intended. Let me prepare!

from centraldogma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.