Giter VIP home page Giter VIP logo

Comments (3)

vim-zz avatar vim-zz commented on June 1, 2024

@yakirm-cr this is by design, the idea was that when using rankByGitBlame to assign reviewers automatically with add-reviewers@v1 then mapping users to null is a way to prevent the automatic mapping in certain cases, like in your example contributors that are not longer part of the team.

- action: add-reviewers@v1
  args:
    reviewers: {{ repo | rankByGitBlame(gt=25) }}  <--- this will drop `null` users

On the other hand, when using explainRankByGitBlame with add-comment@v1 it still shows these users details in the PR comment suggestion as this info might be valuable by itself.

- action: add-comment@v1
  args:
    comment: |
       {{ repo | explainRankByGitBlame(gt=25) }}  <--- this will NOT drop `null` users

tl;dr the comment will not suggest null users but will show them in the details.

from gitstream.

yakirm-cr avatar yakirm-cr commented on June 1, 2024

@vim-zz Thanks for the clarification!
I suggest to add it to the documentation (I suspect other may face the same and raise it again).

from gitstream.

vim-zz avatar vim-zz commented on June 1, 2024

Added - thank you for the feedback!

from gitstream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.