Re-trigger gitstream after submitting a review about gitstream HOT 9 CLOSED

@matthewparavati this will be covered in #18 - working on this :)

from gitstream.

@matthewparavati we added this to the roadmap, I don't have definite timeline yet

from gitstream.

@matthewparavati

  requested_changes:
    if:
      - {{ pr.status == 'open' }}
      - {{ pr.requested_changes | length > 0 }}
    run:
      - action: add-label@v1
        args:
          label: '🚨 Changes requested'
          color: '#EC560D'

from gitstream.

@vim-zz perfect, thanks! Did you want me to leave this open for now or close and just track the progress of issue 18?

from gitstream.

@vim-zz Actually, after submitting some more PRs today with requested changes, gitstream seems to be running again, but my automation check always evaluates to false.

I tried updating it to this earlier today just to see if my check was too specific but it's still evaluating to false.

requested_changes:
  if:
    - {{ pr.status | includes(list=['requested-changes', 'Changes requested', 'requested', 'changes', 'Changes']) }}
  run:
    - action: add-label@v1
      args:
        label: '🚨 Changes requested'
        color: '#EC560D'

Couple follow up questions:

• Is it possibly just the case that the PR status isn't actually up to date when the check occurs? Or is something wrong with my automation check?
• Is there a way to check the PR status when the automation is running?

from gitstream.

@vim-zz any updates/thoughts on this? It always seems to be evaluating to false after submitting a PR review with requested changes

from gitstream.

@vim-zz thanks for the update. should the requested_changes array be zero after changes are resolved or once the user approves the PR?

Basically, we aren't seeing the label getting removed once it's been added and wondering if this is expected?

from gitstream.

@matthewparavati the list clears when all issues are resolved. Do you see gitStream triggers a new check after the changes are resolved? If not, this is a bug. If it tirggers bug doesn't change the resolution it's might be anoter problem

from gitstream.

@vim-zz I was able to re-test and I did not see a new gitstream check after marking a requested change as resolved, I created #153 as a follow up to this

from gitstream.