Giter VIP home page Giter VIP logo

Comments (3)

tricoder42 avatar tricoder42 commented on August 24, 2024 1

I'm thinking about one possible workaround: every time active language is changed or message catalog updated, generate unique i18n-hash. withI18n will pass i18n object and i18nHash prop. This should work with PureComponent out of the box, as it does shallow comparison of props.

The only drawback is, that component will receive one extra prop. Every prop has a risk of possible collision with user-defined props, but i18nHash should be relatively safe to use...

from js-lingui.

tricoder42 avatar tricoder42 commented on August 24, 2024

You're right, messages and active languages and propagated using context. However, there's a subscribe/broadcast mechanism to bypass these kind of problems and triggering forceUpdate automatically when language is changed or messages are loaded.

I'll take a look into it. I think it might be caused, that WithI18n triggers forceUpdate on itself, but underlying PureComponent still ignores it. I tested it only with translated component inside PureComponents (not PureComponent inside translated one).

from js-lingui.

tricoder42 avatar tricoder42 commented on August 24, 2024

Fixed in [email protected].

i18nHash is passed down from withI18n HOC by default. It can be disabled using withHash = false option (withI18n({ withHash: false })).

More info in docs

from js-lingui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.