Does chaoskube really kill the pods? about chaoskube HOT 11 OPEN

@linki the #104 pull request seems to be marked as failing in CI build ...

from chaoskube.

@ljanatka Thanks for checking it out!

from chaoskube.

Hi @linki

from the release notes it seems that chaoskube now can "hardkill" the pods. However I did not find any switch that would activate this feature. Or is the hardkill now implemented as default kill method?

Thanks!

from chaoskube.

This is a very good question. I also assumed that chaoskube was killing the pods. I think killing a pod instead of terminating it is be the best option, because "graceful shutdowns" rarely happen on production environments :)

Would it be possible to at least include a flag to choose the behaviour you want (kill vs terminate)? I'm thinking about adding a configurable gracePeriod in the call to delete the pod. Sounds good?

from chaoskube.

@ljanatka @palmerabollo I agree. There's already a pull request for it by @jakewins: #104. It would help me a lot if you would also have a look and leave some feedback.

from chaoskube.

@ljanatka I just fixed it in case you want to give it a try again.

from chaoskube.

@linki Hi, we finally got to give it a try.
As far as I know, it works quite well. The pod gets killed from the inside, the cluster detects this and restarts it (restart counter of given pod increases, new instance of the pod is not being created).

from chaoskube.

@linki Hi, was my test enough to merge this "hardkill" feature into new version of chaoskube? When do You expect the new version to be released?
Thanks!

from chaoskube.

@ljanatka I'm not sure. I want to refactor it a bit before merging and I have a work-in-progress branch for it.

@jakewins has a fork of chaoskube where this is merged. You could try using it in the meantime.

from chaoskube.

Hi @ljanatka,

https://github.com/linki/chaoskube/releases/tag/v0.12.1 extracted the current strategy into a separate object behind an interface in order to make it easier to add more ways to terminate a pods.

The actual "termination-by-kill" termination strategy from the original PR hasn't been ported over yet.

from chaoskube.

It's been quite awhile now since this feature was requested and I see some refactoring was done. Is there any chance this could be looked at again soon?

from chaoskube.