Giter VIP home page Giter VIP logo

Comments (13)

msiegenthaler avatar msiegenthaler commented on August 16, 2024

We'd have to build a separate image per plugin I think, I don't see a way around that.

So I think the main thing we could improve here is to somehow modularize the scripts a bit, so it's easy for an extending image to hook into certain phases of the lifecycle.
I've never used a helm plugin, so I don't feel very fit on defining possible extension points. The value-store example use case as I understand it would probably want to replace to upgrade/install commands, right?

from concourse-helm-resource.

TimJones avatar TimJones commented on August 16, 2024

In the case of helm-value-store plugin, it only wraps the install\upgrade commands to be able to pull the 'values' from a separate backend (currently only DynamoDB is supported). Other plugins do widely different things that don't make much sense to support in a concourse resource (E.G. properly templating your chart without the need to run a --debug --dry-run against Tiller).
I'm happy to help modularise the current code, helm config setup is already nicely put in common.sh.

from concourse-helm-resource.

msiegenthaler avatar msiegenthaler commented on August 16, 2024

Ok, so the best course of action would be to try to modularize all the code.
Do you think bash is still the right choice as a programming language or would you prefer a switch?

from concourse-helm-resource.

josdotso avatar josdotso commented on August 16, 2024

+1
Here's a Helm plugin we require to move forward with using concourse-helm-resource : https://github.com/hypnoglow/helm-s3

from concourse-helm-resource.

msiegenthaler avatar msiegenthaler commented on August 16, 2024

see #61

from concourse-helm-resource.

amnk avatar amnk commented on August 16, 2024

I'm using helm-secrets plugin. Can it be added in a similar fashion? I think I can help with PR if needed.

UPD. This plugin is ideal for storing secrets in GIT itself, without any external secrets storage.

from concourse-helm-resource.

msiegenthaler avatar msiegenthaler commented on August 16, 2024

Yes, the plugin sound useful. We don't use it ourselves so we'd need a PR for it.

from concourse-helm-resource.

evelant avatar evelant commented on August 16, 2024

I'm trying to use concourse-helm-resource with the helm-gcs plugin. When I go to deploy I get "could not find protocol handler for: gs". Is this due to lack of plugin support in consource-helm-resource? See the helm issue here helm/helm#3938

from concourse-helm-resource.

msiegenthaler avatar msiegenthaler commented on August 16, 2024

I suggest we add the gcs plugin to https://github.com/linkyard/helm-chart-resource
It makes more sense to separate downloading and deploying, because that's the way concourse normally does things.

from concourse-helm-resource.

corey-aloia avatar corey-aloia commented on August 16, 2024

I notice that in the Dockerfile it already installs a helm plugin. It would be great if there was a 'plugins' array as input. Or, even better, if there was a hook so that someone could run a custom script :)

from concourse-helm-resource.

msiegenthaler avatar msiegenthaler commented on August 16, 2024

So it'd install all those plugins basically as the first step in the script, right?

What kind of plugins would you use it for? Just asking because you still won't be able to call arbitrary commands, only upgrade.

from concourse-helm-resource.

corey-aloia avatar corey-aloia commented on August 16, 2024

I was thinking about this today, and what would be awesome would be if we could pass a script as input which could be run before the rest of the scripts. This would allow for doing some custom things. Like with the s3 plugin, someone could use the script to install it and to create the ~/.aws/config file which it needs. It would probably cover a lot of other scenarios as well. For example, it would allow me to do a bit of extra debugging by echoing the state of things.

from concourse-helm-resource.

msiegenthaler avatar msiegenthaler commented on August 16, 2024

Implemented

from concourse-helm-resource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.