Giter VIP home page Giter VIP logo

Comments (6)

arbourd avatar arbourd commented on July 17, 2024 1

@mkotsalainen I would just use the metadata resource and build a release file with the name. I'm doing that myself in a pipeline and it works fine.

from concourse-helm-resource.

mkotsalainen avatar mkotsalainen commented on July 17, 2024

Ok it's this line (in the out shellscript) that is causing the cat error above:
release=cat $source/$release_file

When I try skip the release parameter (according to readme it is optional) I get the following error:

Running command helm upgrade --install --tiller-namespace kube-system --namespace default stable/redis | tee /tmp/log
Error: This command needs 2 arguments: release name, chart path

from concourse-helm-resource.

mkotsalainen avatar mkotsalainen commented on July 17, 2024

Ok I know what is wrong now. I didn't realize that release is supposed to be a file, not a string. I'll bet a bunch of others get burned by this.

If you don't specify a release in the resource_type or the put def, you'll get the helm upgrade error I wrote about earlier. There should probably be a check there and do a regular helm install if the release param isn't present. If you want I could do a PR with that fix.

from concourse-helm-resource.

arbourd avatar arbourd commented on July 17, 2024

I just went through this myself.

I think it should be either a file or a string. The reason I want a string is, I'm deploying many Helm charts to the same resource, with different release names.

I have my own patch at https://github.com/arbourd/concourse-helm-resource/commit/4477167248b0890b38ce83be9a5b125f00c2100b. Image available here for the meantime https://hub.docker.com/r/arbourd/concourse-helm-resource

from concourse-helm-resource.

mkotsalainen avatar mkotsalainen commented on July 17, 2024

I can see the reason for it being a file - that makes it more dynamic. I agree that both string and files should be allowed.

My use case is that I wanted to install a chart with a few datastores that we could run our integrationtest against. I wanted the helm chart to be installed with release-name ci-build-$BUILD_ID.

I thought I could use the file option for that - I just needed to get the $BUILD_ID into a file. The only problem is that only resources get that parameter, not tasks. I could use this https://github.com/vito/build-metadata-resource along with a task but instead I chose to hack up a verision of this resource for myself: release_build_number_string_prefix parameter: mkotsalainen@5ac105f

Maybe someone has a better idea of how to achieve what I want?

from concourse-helm-resource.

msiegenthaler avatar msiegenthaler commented on July 17, 2024

It can now be a file or a string, thanks to the PR by @arbourd

from concourse-helm-resource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.