set_multi() raises AttributeError if connection is closed between readline() calls about python-memcached HOT 8 CLOSED

I don't know the code well enough to know what the exact fix should be, but I think it should be something along these lines:

• have set_multi() call readline() with raise_exception=True and catch the _ConnectionDeadError in the except clause
• add the rest of the keys that we haven't set successfully to the nonstored list (have to keep track of this somehow, with an index counter or something)

from python-memcached.

First of all, thanks so much for tracking this down and creating the test. I've set up a tests directory and put this test in place.

My thinking is that we will probably want to check for socket going None in the set_multi code and treat them like misses. I'm going to need to do some digging though.

from python-memcached.

I've pushed a new version which causes readline() to behave a bit more sanely. This resolves the exception from your test. Can you please review?

Thanks,
Sean

from python-memcached.

Thanks for the quick turnaround. I commented on the commit.

from python-memcached.

I could have sworn that I commented on this, but I don't see one on this comment or on the commit you commented on. I've committed a new version which I believe resolves these issues as discussed in the commit. Can you review and let me know if this looks good and if it resolves the issues you are having?

Thanks,
Sean

from python-memcached.

Yep, commit 8116cfe works and looks good to me, thanks!

from python-memcached.

I've pushed out a new release that includes this patch. Thanks again for your help on this.

from python-memcached.

No probs, thanks for fixing!

from python-memcached.