Consolidate with another fork? about django-pyodbc HOT 6 CLOSED

That would be fantastic--thanks for bringing this up. I suppose GitHub's repository search let me down!

I really appreciate the offer. I'll do a diff on the two repos and see what's different between one and the other. My main improvements so far have involved the project structure and getting things to a more consistent state, but I'm sure there is a ton I've left out.

Thanks again 👍

from django-pyodbc.

Not a problem. Again, my goal here is to have a place to point people to if they try to access my repository; which I can't do in good faith unless your fork works as well :)

I found out about this fork from a user named murr4y on IRC, who tracked me down from some #django irc logs and told me he was using this fork and encountered an exception; that's when I pointed him to mine. He said that my fork, with the addition of a patch from your fork (some more version logic in base.py and get_ordering() needs to take a ordering_group_by parameter), made everything work swimmingly on 1.5.

The biggest problem you'll have, I think, will be getting a proper diff considering the structure/consistency changes you've already made, but I'm sure you'll figure it out. If I can be of any assistance, please just ask in this issue and I'll do what I can.

You can also gain value from the existing issues and pull requests on my fork I'm sure; those are valid issues but not ones that we had actually encountered at my previous employer and so I let the issues/PRs stagnate.

from django-pyodbc.

Awesome--I'm going to scope around and find some good test cases for all the issues people have run into. I may just run diff manually on a file by file basis to figure out the differences.

Will update this issue when I think things are more stable (after taking into account the improvements from your repo and checking out around the Internet). Getting a working test suite (#1) is also high on my list, as it'll make merging improvements a ton easier.

from django-pyodbc.

Just went through and merged in a ton of improvements in the compiler code. I checked out everything else and that was where the bulk of the differences were.

963aae5

Added you to the authors list as well:

b7beb02

from django-pyodbc.

Does this mean the docs should be updated to reflect that all the tests (should?) be passing or can I take a look and see what needs attention?

from django-pyodbc.

@codalab the tests should be passing. Unfortunately, I haven't had as much time as I'd like working through these issues. It would be great if all the tests passed, and would appreciate any help on that front :)

from django-pyodbc.