Comments (10)
Hmmm... that's a tricky one.. cause in a way it belongs to category social :) you could get it and rename it.. but eventually if become popular it will be blocked again.. not much we can do I guess
from bootstrap-social.
FWIW, I've gotten several emails from users who were confused and frustrated that they couldn't log in to my site. It took some digging to learn this was the issue.
I've tested locally and confirmed that simply changing the class name to something other than btn-facebook prevents the blocking. Something like btn-soc-facebook successfully bypasses the block, and seems reasonable in the scope of this project (adds a layer of namespacing, which might be a good thing anyway).
The /intent/ of fanboy-social, as I understand, is to block the fancy embedded share buttons that track you as you move around the web, /even when you don't click them/. I say that based on this post:
https://adblockplus.org/blog/about-that-facebook-tracking-thing
So I think making this adjustment is /not/ just playing a game of cat and mouse. I don't think the author(s) of fanboy-social would feel it necessary to adjust their list to block bootstrap-social buttons--I think they were blocked unintentionally. Therefore I claim this classname change would be purely a bugfix.
I understand project maintainers might disagree with this claim though, and a class name change kinda breaks backwards compatibility. But if project maintainers agree with me, I'm happy to write a PR. Let me know.
from bootstrap-social.
Spoke too soon...the fix I'm proposing almost works, but the fontawesome icons still get blocked.
The fact this filter blocks fa- classes is ... ugh. Perhaps they /do/ intend to block /all/ buttons /in any way related/ to social. I know /my/ users who have installed this are disappointed with the behavior though. At least some of them. Ugh.
Considering merging fa into my codebase and also tweaking their classnames...That probably isn't really a viable solution for this library as a whole though. So now I'm thinking this bug is a WONTFIX :/
from bootstrap-social.
Relevant thread on the fontawesome project:
FortAwesome/Font-Awesome#1799
from bootstrap-social.
@gameguy43 Thanks for the research, the follow up and the links.. Of course the icons are not part of this lib, but nevertheless I believe even if we're going to change the prefix they will do something else to block them, as they are blocking all the social stuff.. even when it's actually needed and not intended to spam or annoy people.. I'm not sure if there is any way to bring that subject to AdBlocker or something, as these buttons started and intended to be used as sign in buttons..
from bootstrap-social.
what we need is to have a post process to personalize the entire stack to me. This would obfuscate all names to my organization, hence never get noticed as popular usage. i.e. I believe Bootstrap has some sort customization on their site to make a custom bootstrap just for me, minus the obfuscation.
from bootstrap-social.
I think I'll just close this one.. not much we can do.. right?
from bootstrap-social.
FWIW: a bit of movement on this recently. Fingers crossed!
FortAwesome/Font-Awesome#1799
https://issues.adblockplus.org/ticket/4434
from bootstrap-social.
From: https://lipis.github.io/bootstrap-social/
<a class="btn btn-social-icon btn-twitter">
<span class="fa fa-twitter"></span>
</a>
<a class="btn btn-block btn-social btn-twitter">
<span class="fa fa-twitter"></span> Sign in with Twitter
</a>
Might be happier if they removed the class social suggestion's of using the
btn-twitter
btn-facebook
btn-[....]
btn-social-icon
Then we can simply remove the fa-[elements] from the social list.
from bootstrap-social.
Hi, I have still problem with btn
btn-facebook
classes:
<div class="btn-group-justified" role="group">
<div class="btn-group" role="group">
<!--- This element is hidden -->
<a class="btn btn-facebook" href="">
<span class="fa fa-facebook"></span> Facebook
</a>
<!--- This element is NOT hidden -->
<a class="btn btn-google" href="">
<span class="fa fa-google-plus"></span> Google +</a>
</div>
</div>
from bootstrap-social.
Related Issues (20)
- Violates Google Sign-In Branding Guidelines
- Fontawesome 5 support
- No Social Badges HOT 3
- A problem that might caused by bootstrap4 and fontawesome5 HOT 2
- Request: btn-grey for use in footer
- Update sample image HOT 1
- Add support bootstrap 4 HOT 4
- Set focus color
- npm installation error
- Thingiverse button
- In showcase website. Color of Tumblr is wrong.
- Google sign-In Branding not compliant HOT 3
- Facebook sign-in branding not compliant HOT 2
- font awesome 5 fab- instead of fa-
- Application for new maintainers? HOT 5
- No Apple ID connect button ? HOT 1
- Icons not showing up in chrome
- Social media share
- Add a button for Discord.
- Hackernews
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap-social.