Giter VIP home page Giter VIP logo

Comments (6)

lipis avatar lipis commented on May 29, 2024

Can you create a JSFiddle or something with the problem?! I really hate !important and I'm wondering why is that needed..

from bootstrap-social.

topless avatar topless commented on May 29, 2024

You might be importing your custom css file before bootstrap. Make sure you have it last on the list.

from bootstrap-social.

DrewCPU avatar DrewCPU commented on May 29, 2024

http://jsfiddle.net/DrewCPU/xm5Dr/ has everything loaded and you can see the issue. I find that adding !important to the padding on .btn-social, the white color attributes, and the hover background colors fixed the problem for me. I also moved the color attribute up to .btn-social instead of leaving it for every social network on my site (http://www.mywebwishlist.com).

from bootstrap-social.

lipis avatar lipis commented on May 29, 2024

In order to fix this problem few !important here and there will just make it more complicated because Bootstrap has many rules that are applied to the <a> of the navbar.

I would suggest you to change the links to <button> and handle them using JS.. by doing that you just need to adjust the width/height of the icon to match the Flatly theme because you're not using the .less files..

Check this example here.. and notice that I have very few changes:
http://jsfiddle.net/xm5Dr/6/

screen shot 2014-01-21 at 18 50 51

from bootstrap-social.

lipis avatar lipis commented on May 29, 2024

Just in case you want to avoid using JavaScript for the <button> because I changed from <a> you can wrap it inside a <form> and simulate the normal link like this:

<form action="/login/facebook">  
  <button class="btn btn-block btn-social btn-facebook">
    <i class="fa fa-facebook"></i>
    Sign in with Facebook
  </button>
</form>

The above code is more or less similar to the

<button class="btn btn-block btn-social btn-facebook" href="/login/facebook?">
  <i class="fa fa-facebook"></i>
  Sign in with Facebook
</button>

from bootstrap-social.

DrewCPU avatar DrewCPU commented on May 29, 2024

That'll work for me. Thanks for all your work on these buttons.

from bootstrap-social.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.