Validate does not fail when "columns" list contains tags that are not "column" about liquibase HOT 3 OPEN

Hi @vtheuer,

Thank you for raising this issue for us. Currently, Liquibase does not validate JSON/Yaml schemas and to make that available a good amount of work is required. Our team has other priorities for the near future, but thanks to this issue and some others we have been working on we decided to consider adding a JSON/Yaml schema validator and put it in our backlog (for Liquibase 5). With that said, if you are keen to submit a PR for adding a change object validation to consider cases like the one you reported here that would be more than welcome, and we would be happy to review it or answer any question you might have.

Thanks,
Daniel.

from liquibase.

Hi @MalloD12,

I am indeed keen to submit a PR regarding this issue.

After skimming through the code, I believe the check cannot happen in the validate phase, as it operates on already-parsed changes. I think the code that should be updated is in AbstractChange.load. Would it be OK to throw that kind of exception during the parse phase ?

I'm having trouble understanding how tests are arranged, could you point out which unit and integration tests are linked to this method ?

Finally, don't hesitate to tell me if this is not the right place to have this discussion.

Thanks in advance,
Virgile.

from liquibase.

Hi @vtheuer,

Virgil in my opinion, updating AbstractChange.load() method could work, but I think that's not the right place. For the given case, doing a change like that one would be a workaround. Currently, these types of validation errors do not happen in XML format, because the XSD validations are triggered and prevent you from creating an invalid changelog. I think to fix this we should add similar support for JSON/YAML format, and to do that we can use the xml XSD schema (using a third-party library) as a starting point. If we create a PR updating the load() method that may work for this case, but we will need to remove that piece of logic in the future when the mentioned solution is implemented.

Thank you for proposing ideas, that's very appreciated by the team.

Daniel.

from liquibase.