Giter VIP home page Giter VIP logo

Comments (3)

MalloD12 avatar MalloD12 commented on June 12, 2024

Hi @marwin1991,

If you see it duplicated yes I agree we should get rid off one of them. I can see org.apache.commons:commons-text is included by com.opencsv:
Screenshot 2024-05-07 at 12 21 27 AM

I don't see commons-text as a sole dependency of core. If you don't mind could you please share where are you seeing both duplicates?

Thanks,
Daniel.

from liquibase.

marwin1991 avatar marwin1991 commented on June 12, 2024

@MalloD12
sorry for westing your time, I don't know why i thouth it is

i've tested it with:

mvn
      --batch-mode
      validate
      org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce
      -Denforcer.rules=banDuplicatePomDependencyVersions,dependencyConvergence

and it looks okay.

output of mvn dependecy:tree for me looks a bit diffrent:

image

And it looks like here core contains commons-text and opencsv

from liquibase.

MalloD12 avatar MalloD12 commented on June 12, 2024

Hi @marwin1991,

I can see now what you mean. I've been talking with one other member of the team and he pointed me out to the generated pom file and I can see what you were pointing out there.

Maybe we should add common-text as a core dependency to avoid this being included as an inherited dependency, same with commons-collections4. Do you have any other proposal to fix this?

Thanks,
Daniel.

from liquibase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.