Giter VIP home page Giter VIP logo

Comments (6)

cvalkan avatar cvalkan commented on September 15, 2024

Aave

https://docs.aave.com/developers/developing-on-aave/the-protocol/price-oracle
https://github.com/aave/aave-protocol/blob/master/contracts/misc/ChainlinkProxyPriceProvider.sol

Screenshot 2020-10-28 at 11 17 23

MCDEX

https://github.com/mcdexio/mai-protocol-v2/blob/2fcbf4b44f4595e5879ff5efea4e42c529ef0ce1/contracts/oracle/ChainlinkAdapter.sol
Screenshot 2020-10-29 at 17 42 29

This Band Protocol integration may also be worth checkin out:
https://github.com/FinNexus/chainLinkBridge/tree/master/contracts

from dev.

ricktobacco avatar ricktobacco commented on September 15, 2024

@cvalkan are you going to implement one of these, or will we make a design doc first?

from dev.

cvalkan avatar cvalkan commented on September 15, 2024

I've gone through all projects listed on https://feeds.chain.link that are using ChainLink's ETH:USD, and I only found Aave to be using a fallback solution, but only for complete outages as it seems (where price = 0).

According to page 4 of this whitepaper, Lien Protocol is using a proper fallback mechanism, but the project seems to be closed source .

I fear that we won't be able to use/copy any existing fallback solution.

from dev.

ricktobacco avatar ricktobacco commented on September 15, 2024

There's a line I liked from mai, but I'm not sure what AAVE is doing.
https://liquity.slack.com/archives/CR0CYAUBD/p1606522241108900

from dev.

cvalkan avatar cvalkan commented on September 15, 2024

It seems that at some point AAVE was using Uniswap v1 as its main oracle and Chainlink as a fallback (at least on Kovan):

Screenshot 2020-12-13 at 12.29.56.png
Screenshot 2020-12-13 at 12.30.26.png

ConsenSys Diligence audited the code and had some criticism: https://consensys.net/diligence/audits/2020/05/aave-cpm-price-provider/

from dev.

ricktobacco avatar ricktobacco commented on September 15, 2024

ConsenSys Diligence audited the code and had some criticism: https://consensys.net/diligence/audits/2020/05/aave-cpm-price-provider/

"detects manipulation by comparing the price derived from the state of the Uniswap exchange to the price provided by the Chainlink oracle. If the prices differ significantly, the Chainlink price is taken as correct..."

"In the case that Uniswap is more current than Chainlink, the error margin would be limited to the size of the price change in real world markets..." not sure what they mean here

from dev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.