Comments (4)
The middleware will need updating around this piece:
dev/packages/lib-ethers/src/EthersLiquity.ts
Lines 285 to 297 in 61a7ee9
As you can see it's currently picking the first element of the return tuple of findInsertPosition as hint, but we could just as well take both.
from dev.
I recommend making this change after #94 to avoid conflicts.
from dev.
Fixed in #228
from dev.
🎉 This issue has been resolved in version @liquity/lib-ethers-v1.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from dev.
Related Issues (20)
- how to show the redeem part in the dev env
- the ability to use the Avalanche C-Chain.
- Hi can u explain n edit this to true where its false and how can I add this file to the trading app HOT 1
- Typo in file name LSUDUsdToLUSDEth.sol HOT 1
- Unable to access https://liquity.app/
- Prerequisites not properly defined
- Repository for "concat-stream" missing
- Deployment requires discontinued testnets
- yarn install fail HOT 1
- `SortedTroves. insert` is vulnerable to developer error
- Liquidity
- Liquidity/dev
- Errors when running test HOT 11
- Uniswap doesn't have the required data to calculate yield HOT 9
- Test bug - a lib-ethers test calls getLQTYBalance instead of getLUSDBalance HOT 1
- docs: private development chain link is broken
- Docs: AdjustTrove documentation seem outdated
- Okan
- Chickenbond front end does not work with Ankr RPC HOT 3
- Fix UI layout for Mobile Browsers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dev.