Problem when downloading invoices about daloradius HOT 3 CLOSED

Both PHP notices refer to some missing text keys in the language array / file correspoding to the language you are selected when running Daloradius.

In fact, they are not even in the language by default (English) located at:

\daloradius\lang\en.php

PHP Notice: Undefined index: billinvoicesedit in /usr/share/nginx/html/daloradius/bill-invoice-edit.php on line 265

Refers to:

<?php echo $l['helpPage']['billinvoicesedit'] ?>

PHP Notice: Undefined index: user_idTooltip in /usr/share/nginx/html/daloradius/bill-invoice-edit.php on line 354

Refers to :

<?php echo $l['Tooltip']['user_idTooltip'] ?>

The obvious solution to this problem is just adding the two missing text keys and its corresponding translations to the languages files, or, at last in the English one.

Or simply don't care about these PHP notices.

from daloradius.

@MiguelVis Thanks for your answer,
But what would these keys correspond to? I mean what would be an "example value"? Because I don't really understand what is the point...

Thx

from daloradius.

Sorry, I had no idea. Maybe they correspond to the section title, and a tooltip explanation. Ask @lirantal .

I suposse that the problem here is that PHP version 7 is more restrictive with PHP Notices than older versions.

If you ask for a quick and dirty solution, you could do one of two things.

1.Add the following two lines to the file \daloradius\lang\en.php:

$l['helpPage']['billinvoicesedit'] = '';
$l['Tooltip']['user_idTooltip'] = '';

or

2.Comment the two offensive lines in the file daloradius/bill-invoice-edit.php:

line 265:
// <?php echo $l['helpPage']['billinvoicesedit'] ?>

line 354:
// <?php echo $l['Tooltip']['user_idTooltip'] ?>

I prefer the first option. Maybe even you could submit a PR with your patch, because it seems an old bug.

PD: I have created myself the PR #68 to solve this problem. Please, @lirantal check.

Anyway, it seems that Daloradius has a lot of similar problems with language items :(

from daloradius.