How to skip maxPercentIncrease for certain PR about bundlemon HOT 7 CLOSED

See here: #115 (comment)

Forgot to document this ability, but let me know if this solves the issue for you

from bundlemon.

Yes. It's amazing!

Quick question about the behavior, if I set the limit by max increase percent and I approve the change that increases the binary size, will the next PR fail the bundlemon CI again since the baseline didn't change and the binary size will stay high?

from bundlemon.

yes, each approval is for a specific commit, the baseline will always be the target branch, once you merge the baseline will change.

from bundlemon.

I found two issues when trying this feature:

1. After I approve the change, the bundlemon CI job still fails. I was expecting it to pass.
2. There is a race condition in the UI between when the review button checks auth state and the auth state changes. If auth state changes after the review button checks the auth status, it will show me log in is required even if I have logged in.

from bundlemon.

The approval applies to a specific commit that goes to GitHub and changes the current commit status from failed to success, re-running or a new commit will cause it to fail again.

We can think of a solution that checks the PR labels and auto-approves new jobs.

For now, you can do that bundlemon wont fail the pipeline

- name: Run BundleMon
   uses: lironer/bundlemon-action@v1
   with:
     fail-on-error: false

Then your job will always be successful, and if you want to verify the bundlemon status have a "required" status of the bundlemon commit status

from bundlemon.

Yeah, having a way to auto approve the jobs with a PR labels can be a great idea.

Do you mind elaborating what you meant by "have a "required" status of the bundlemon commit status"

Thanks for the reply!

from bundlemon.

1. Setup bundlemon github-integration, then on every commit in a PR bundlemon will add a commit status

2. In branch protection rules, make BundleMon a required status check
   

When one of the defined limits exceeds BundleMon will create a failed commit status, You can decide if you want to approve it via the BundleMon website. If you approve it will change the commit status to success

from bundlemon.