Deion I want to configure a custom exception handler for the

Bug: exception_handlers are not applied when debug flag is False about litestar HOT 2 CLOSED

TheZwieback commented on June 28, 2024

Bug: exception_handlers are not applied when debug flag is False

from litestar.

Comments (2)

Alc-Alc commented on June 28, 2024

Not sure I understood this, you are applying the exception handler to LitestarException but your route handler raises a different exception, so how is it you expect it to trigger?

Your MCVE never applies the handler even if debug = True for the same reason stated above

from litestar.

TheZwieback commented on June 28, 2024

Thanks, I see my mistake. I assumed the LitestarException map would catch all exceptions for some reason. I checked the code and if I use the correct error mapping it works. Here is the working example for completeness:

from litestar.exceptions import HTTPException
from litestar.status_codes import HTTP_500_INTERNAL_SERVER_ERROR
from litestar import Request, Response, Litestar, post

import logging


def exception_handler(_: Request, exc: Exception) -> Response:
    if isinstance(exc, HTTPException) and exc.status_code != HTTP_500_INTERNAL_SERVER_ERROR:
        status_code = getattr(exc, "status_code", HTTP_500_INTERNAL_SERVER_ERROR)
        detail = getattr(exc, "detail", "")

        return Response(
            content={"detail": detail},
            status_code=status_code,
        )

    logging.exception(exc)
    status_code = HTTP_500_INTERNAL_SERVER_ERROR
    detail = {"special_detail": "Internal Server Error"}

    return Response(content=detail, status_code=status_code)


@post(
    "/test",
)
async def test() -> Response[str]:
    1 / 0
    return Response("test")


app = Litestar(
    route_handlers=[test],
    exception_handlers={Exception: exception_handler},
)