C89: Code is written for C99 about littlefs HOT 8 CLOSED

This is also a problem (but easy enough to fix):

const lfs_block_t tpair[2] = {pair[0], pair[1]};

if (lfs_paircmp(oldpair, (const lfs_block_t[2]){0, 1}) == 0) {

from littlefs.

Related #39

Out of curiousity what is creating the requirement for C89?

from littlefs.

The compiler I’m using doesn’t support c99!

I completed most of the changes, I know it’s down to coding styles but some of the places you’ve used named initialisers actually creates more lines of code than not using them!

Once I’ve completed my changes, I’ll clone to the repo and copy my files over the top and go through the git changes to make sure I didn’t mess anything up.

happy to send back across, I saw somebody else having issues with c89.

i’ll Admit that on new projects I’m using a different build system, so c99 isn’t a problem and I do use it, but I think littlefs is such an important project that comparability across as many platforms is a desirable feature.

from littlefs.

I'm just curious which compiler it is.

But no, you're right (and @kgillespieatmosphere). It'd be a shame if other had to duplicate your efforts.

I'd be happy to host a c89 version, but I would prefer to treat it as a port to a different language.

If you have changes that compile in c89, feel free to create a pr. I'm thinking I'll create it's own repo and link to it from the README.

from littlefs.

Huh, after I'd finished making the last change I realised there was a compiler option to turn on c99 compatibility!

Hangs head.....

from littlefs.

Haha, well that's an easy solution.

Offer still stands to create a branch for C89 if anyone wants to create a pr for it.

from littlefs.

@geky I'm happy to close this one, I agree it's a non-issue and keeping up to date between a C89 and C99 variant would be a waste of time and effort.

from littlefs.

Thanks! Sorry there's a lot of lingering open issues. I need to go through all of them but haven't had a good chance to yet.

from littlefs.