Giter VIP home page Giter VIP logo

Comments (8)

isaqueprofeta avatar isaqueprofeta commented on August 11, 2024

I can help you with this... let's first merge the bug from #20 ok?

from redisbeat.

liuliqiang avatar liuliqiang commented on August 11, 2024

Thanks @isaqueprofeta, that's great.
I assigned this issue to you.

from redisbeat.

isaqueprofeta avatar isaqueprofeta commented on August 11, 2024

I made two options in branches on my fork:

You can try them (I also updated the README.md with instructions) and tell me which one do you want me to pull request, personally I find more elegant to use pure docker-compose, even with doubled code from examples.

from redisbeat.

liuliqiang avatar liuliqiang commented on August 11, 2024

@isaqueprofeta that's great to see your different try.

After reviewed the two way, I prefer the pure docker-compose version,for these reason:

  • People will clearly know there are 3 component
  • As container practice, it's best to run only one process in one container
  • It will also show that our redis beat not only support localhost, we have config CELERY_REDIS_SCHEDULER_URL to specify redis addr.

I also add some comment in the commit.

from redisbeat.

isaqueprofeta avatar isaqueprofeta commented on August 11, 2024

Great to see that we have the same opinion. I also replied to the comments.

from redisbeat.

liuliqiang avatar liuliqiang commented on August 11, 2024

That's well.
Let's do follow your suggestion, and drop the example by pure local run.
And remind only docker-compose example for users that want to try redisbeat.

from redisbeat.

isaqueprofeta avatar isaqueprofeta commented on August 11, 2024

Can you please review this last commit dropping the local example? The most important part I think that is the README.md with the explanations.

from redisbeat.

liuliqiang avatar liuliqiang commented on August 11, 2024

Just a little comment for me.
Others LGTM.

from redisbeat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.