Kino.Input.text slow to render new input about kino HOT 7 CLOSED

animate already keeps a frame for you, so I wonder if the issue is being caused by rendering the same frame twice. Try this instead:

button = Kino.Control.button("Click") |> Kino.render()
items = [[a: "a", b: "b"], [a: "c",b: "d"]]

Kino.animate(button, 0, fn _event, counter ->
  new_counter = counter + 1
  current = Enum.at(items, counter)

  inputs = [
    example_a: Kino.Input.text("Example a: ", default: "#{current[:a]}"),
    example_b: Kino.Input.text("Example b: ", default: "#{current[:b]}")
  ]
  form = Kino.Control.form(inputs, submit: "Send")
  {:cont, form, new_counter}
end)

from kino.

animate already keeps a frame for you, so I wonder if the issue is being caused by rendering the same frame twice. Try this instead:

button = Kino.Control.button("Click") |> Kino.render()
items = [[a: "a", b: "b"], [a: "c",b: "d"]]

Kino.animate(button, 0, fn _event, counter ->
  new_counter = counter + 1
  current = Enum.at(items, counter)

  inputs = [
    example_a: Kino.Input.text("Example a: ", default: "#{current[:a]}"),
    example_b: Kino.Input.text("Example b: ", default: "#{current[:b]}")
  ]
  form = Kino.Control.form(inputs, submit: "Send")
  {:cont, form, new_counter}
end)

Still have the same issue with this code

Edit: Just to confirm it's not an issue with my browser, I switched from Firefox to Chrome, but still run into the same problem.

from kino.

I think there is a race condition happening in

When putting an inspect after output

 def handle_call({:render, term, destination}, _from, state) do 
   output = Kino.Render.to_livebook(term) |> IO.inspect()
   put_update(destination, state.ref, [output], :replace) 
   state = update_outputs(state, destination, fn _ -> [output] end) 
   {:reply, :ok, state} 
 end 

it magically works :-D
Couldn't figure out the details yet.

Here is a simple way to reproduce the error:

frame = Kino.Frame.new()

Kino.Frame.render(frame, Kino.Input.text("Test"))

from kino.

button = Kino.Control.button("Click") |> Kino.render()
items = [[a: "a", b: "b"], [a: "c",b: "d"]]

Kino.animate(button, 0, fn _event, counter ->
  new_counter = counter + 1
  current = Enum.at(items, counter)

  inputs = [
    example_a: Kino.Input.text("Example a: ", default: "#{current[:a]}"),
    example_b: Kino.Input.text("Example b: ", default: "#{current[:b]}")
  ]
  form = Kino.Control.form(inputs, submit: "Send")
  {:cont, form, new_counter}
end)

In the latest Livebook nightly build, this example doesn't even work - the whole session crashes 😅

from kino.

I think there is a race condition happening in

kino/lib/kino/frame.ex

Lines 172 to 177 in f961f8d

	def handle_call({:render, term, destination}, _from, state) do
	output = Kino.Render.to_livebook(term)
	put_update(destination, state.ref, [output], :replace)
	state = update_outputs(state, destination, fn _ -> [output] end)
	{:reply, :ok, state}
	end

When putting an inspect after output

 def handle_call({:render, term, destination}, _from, state) do 
   output = Kino.Render.to_livebook(term) |> IO.inspect()
   put_update(destination, state.ref, [output], :replace) 
   state = update_outputs(state, destination, fn _ -> [output] end) 
   {:reply, :ok, state} 
 end 

it magically works :-D Couldn't figure out the details yet.

Here is a simple way to reproduce the error:

frame = Kino.Frame.new()

Kino.Frame.render(frame, Kino.Input.text("Test"))

I can't replicate my issue with this code - this seems to render correctly. I checked out the .10 branch of both Livebook and Kino and changed it to output = Kino.Render.to_livebook(term) |> IO.inspect() but that doesn't seem to resolve the issue with Kino.animate

from kino.

@clayscode I pushed a fix to livebook main. Not sure if its the correct way to tackle the issue, but it works on my side.
Lets see what @jonatanklosko thinks :)

from kino.

@jannikbecher your PR seems to fix my issue, awesome!

from kino.