Comments (2)
Nope! There is a bug into the 2.1.1 version.
I have a custom navigation controller that is the elastictransition delegate. Pushing a uitableviewcontroller, the scroll of the table view will be not recognized.
Anyway, my version of the 2.0.1 is ok (i just putted to optional a lot of variables).
Merge :)
from elastictransition.
@gali8
Thanks for you contribution. After looking at your PR, I dont think that transitionContext
and container
should be nilable. It increased code complexity and we have to do a lot of optional chaining.
The easy way to fix for these crashes that you are experiencing is just to check wether or not we are actually doing a transition before any callbacks that uses these variables. That is what I did for 2.1.1. The tableview bug is caused by another feature that I am adding. I want scrollview to trigger the elastic transition when the user scrolls to the top. I am fixing it right now and hopefully get the 2.1.1 branch merged today.
Again, thanks for the contribution! please let me know if you have any other concerns or experiencing any other bugs.
from elastictransition.
Related Issues (20)
- none animated dismissViewController bug HOT 6
- wrong width when presenting a ViewController on top of ViewController presented by ElasticTransition HOT 2
- Fixed controls while transitioning, how to? HOT 4
- Support NavigationController HOT 2
- Swift 2.3 isn't letting me do performSegueWithIdentifier with this pod HOT 1
- Possible retain cycle found in the example project and my own code HOT 4
- ElasticModalViewController not found HOT 1
- Dragging View issue HOT 13
- Swift 3 HOT 1
- can this transition with transparent background?
- getting !!! Elastic Transition started presenting
- Import issue HOT 1
- Pod Missing ElasticModalViewController HOT 1
- Does not build due to MotionAnimation HOT 1
- Anyone know if there is something similar for android? HOT 1
- ElasticModalViewController "not open" error HOT 1
- Swift 4 update? HOT 2
- How to use it manually or with Carthage?! HOT 3
- Scrollview doesn't work with this library.
- How can I dismiss Menu screen without animation?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elastictransition.