Giter VIP home page Giter VIP logo

Comments (2)

gali8 avatar gali8 commented on July 3, 2024

Nope! There is a bug into the 2.1.1 version.
I have a custom navigation controller that is the elastictransition delegate. Pushing a uitableviewcontroller, the scroll of the table view will be not recognized.
Anyway, my version of the 2.0.1 is ok (i just putted to optional a lot of variables).
Merge :)

from elastictransition.

lkzhao avatar lkzhao commented on July 3, 2024

@gali8
Thanks for you contribution. After looking at your PR, I dont think that transitionContext and container should be nilable. It increased code complexity and we have to do a lot of optional chaining.

The easy way to fix for these crashes that you are experiencing is just to check wether or not we are actually doing a transition before any callbacks that uses these variables. That is what I did for 2.1.1. The tableview bug is caused by another feature that I am adding. I want scrollview to trigger the elastic transition when the user scrolls to the top. I am fixing it right now and hopefully get the 2.1.1 branch merged today.

Again, thanks for the contribution! please let me know if you have any other concerns or experiencing any other bugs.

from elastictransition.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.