BLT v0.5.3 has some build errors related to googletest about blt HOT 7 CLOSED

@adayton1 in the config file, it looks like you're pulling in gcc4.9.3 stuff, which I do not think will work. Try switching to gcc8.3.1

Also, for clang14.0.5 on blueos, we have been building and testing RAJA with and without the --gcc-toolchain option and both seem to work.

from blt.

Can I see the full compile line? What C++ standard are you ending up with? The new gtest requires 14 but there is a check for that so I am confused how that could happen:

@rhornung67 that gcc4.9.3 is an exclude, it is removing that old version.

from blt.

@white238 yes, you are correct sir! My advanced age has affected my ability to read.... 😞

from blt.

Here's the full compile line:

/usr/tce/packages/cuda/cuda-11.7.0/bin/nvcc -forward-unknown-to-host-compiler -ccbin=/usr/tce/packages/clang/clang-ibm-14.0.5/bin/clang++ -DGTEST_HAS_DEATH_TEST=0 -isystem=/path/to/blt/thirdparty_builtin/googletest/googletest/include -isystem=/usr/tce/packages/cuda/cuda-11.7.0/include -O3 -DNDEBUG --generate-code=arch=compute_70,code=[compute_70,sm_70] -Xcompiler=-fPIE -std=c++14 -MD -MT blt/tests/smoke/CMakeFiles/blt_cuda_gtest_smoke.dir/blt_cuda_gtest_smoke.cpp.o -MF CMakeFiles/blt_cuda_gtest_smoke.dir/blt_cuda_gtest_smoke.cpp.o.d -x cu -rdc=true -c /path/to/blt/tests/smoke/blt_cuda_gtest_smoke.cpp -o CMakeFiles/blt_cuda_gtest_smoke.dir/blt_cuda_gtest_smoke.cpp.o

from blt.

@adayton1 -- I ran into this w/ axom here -- LLNL/axom#1120

GTest changed how they handle GTEST_HAS_DEATH_TESTS -- they either want it defined (#ifdef) or not (#ifndef) rather than checking for the value to be 0 or 1. See: google/googletest@dc10c3b

Axom only had one file where that definition went wonky, so I hacked together an ugly fix: https://github.com/LLNL/axom/pull/1120/files#diff-f275c47d3d694fa090c7cccbb29de43d860accc5471d0c5247b4b2e78a7476b6

I also ran into oddities with the new GMock in [email protected] and had to develop a workaround for the MATCHER_P macro: https://github.com/LLNL/axom/pull/1120/files#diff-16066821799ab787292f81096d81bcb88840519839afb5afc392615a796a8a61

Edit: Updated an incorrect link

from blt.

Is there a way we can fix this in BLT without requiring every project to do some fixes like this?

from blt.

Add this to your host-config and it makes it go away:

set(CMAKE_CUDA_FLAGS "-Xcompiler=--gcc-toolchain=${GCC_HOME}" CACHE STRING "")

I will add an example in BLT's host-configs. The current example host-configs have gcc 8.3.1 built in and do not rely on the gcc-toolchain flag on blueos.

from blt.