Question about MLIR FileCheck. about circt HOT 7 CLOSED

Hi @cgyurgyik: the simplest explanation is that the pattern isn't matching and the rewrite not happening. If you set a break point on the replaceOpWithNewOp call, is it getting hit?

Make sure the canonicalization patterns are getting registered correctly.

-Chris

from circt.

No, replaceOpWithNewOp is not getting hit, which is why I thought I was fudging something simple up.
By registered, do you mean it sets the following: hasCanonicalizer = 1 ?

from circt.

Yes, and you need to add some code to register it in getCanonicalizationPatterns for the op: results.insert<YourFolder>(context);.

from circt.

I believe this is also already occurring here:

from circt.

Ok, then I'm not really sure why it isn't triggering - once it does, the filecheck logic should work fine :-). I'd step through the code in a debugger to figure out what isn't happening as you expect. For example, is the if (inputs[size - 1] == inputs[size - 2] line getting reached, etc.

from circt.

Ok so I ended up using a constant as the last two arguments, and it works fine now. Thanks for the back-and-forth!

from circt.

Great!

from circt.