Comments (2)
How do you feel about using the stdlib tokenize
module? It should be pretty trivial to implement this change using it.
If that's fine, then the question is: do we use the old method with this new method, or do we use it as a fallback to double-check non-ASCII strings that have failed the first test? If the new method is slow, it might merit the second approach, but otherwise a simple replacement might be the better option.
from asteval.
@natezb I don't have a strong preference about this. That is, I think it would generally be a bad idea to use non-ASCII as identifiers in code, but I don't know why we should prevent someone from doing that.
I don't know whether valid_symbol_name()
is the only place the "ASCII only" assumption is made, but it would definitely be the place to start. One approach might be to have valid_symbol_name()
short-circuit to always return True
and figure out where downstream code fails.
Does tokenize
help? I think it would be OK to use anything from the standard library, but I'm not seeing immediately how that module would help.
from asteval.
Related Issues (20)
- asteval segfault HOT 5
- Missing dependency in Python 3.7 HOT 3
- Latest release (0.9.26) has importlib_metadata/importlib.metadata bug HOT 7
- Improve the propagation of Exception information (the bad name for a NameError) HOT 2
- List comprehension with multiple "for" loops results in NameError HOT 6
- max_time seems to be unsued HOT 2
- Support regex / glob modules HOT 2
- PyPI: also upload source tarball HOT 2
- power to a negative int HOT 4
- name 'str' is not defined HOT 1
- tests/test_asteval.py::TestEval::test_set_default_nodehandler fails if Python is built without Tkiner HOT 4
- ipmt throws deprecation warning in numpy 2.0.dev HOT 2
- The truth value of a Series is ambiguous HOT 3
- Variable unpacking does not work as expected HOT 8
- Supporting lambda expressions HOT 2
- Python 3.10: test_kaboom fails with IndexError HOT 4
- Import error with python 3.7 due to missing import.metadata HOT 5
- Backward incompatible change is not documented HOT 8
- Does not evaluate types like eval() HOT 6
- Returned value is repeated on next invocation of eval HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asteval.