Giter VIP home page Giter VIP logo

Comments (2)

natezb avatar natezb commented on May 31, 2024

How do you feel about using the stdlib tokenize module? It should be pretty trivial to implement this change using it.

If that's fine, then the question is: do we use the old method with this new method, or do we use it as a fallback to double-check non-ASCII strings that have failed the first test? If the new method is slow, it might merit the second approach, but otherwise a simple replacement might be the better option.

from asteval.

newville avatar newville commented on May 31, 2024

@natezb I don't have a strong preference about this. That is, I think it would generally be a bad idea to use non-ASCII as identifiers in code, but I don't know why we should prevent someone from doing that.

I don't know whether valid_symbol_name() is the only place the "ASCII only" assumption is made, but it would definitely be the place to start. One approach might be to have valid_symbol_name() short-circuit to always return True and figure out where downstream code fails.

Does tokenize help? I think it would be OK to use anything from the standard library, but I'm not seeing immediately how that module would help.

from asteval.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.