Comments (5)
Just verified that modifying the start-container script to include an --advertiseaddr parameter for slimserver.pl does correct this issue - the "Customize Device" settings page no longer tries to connect to 172.17.0.x, and the image thumbnails are now shown.
I just lazily hard-coded the advertiseaddr ip address for this test but will think about the correct fix.
from slimserver-platforms.
Maybe we could add an optional variable like $EXTRA_ARGS
to the startup script (see https://github.com/Logitech/slimserver-platforms/blob/d8120b35f0e8f3991968ab6db1abf22da89ad18f/Docker/start-container.sh#L20). It would be empty by default, but could be set in the Docker command line?
from slimserver-platforms.
I like this idea better than having code specific to --advertiseaddr - makes much more sense.
I do wonder if this has been the wrong approach to my original problem:
JiveExtras::Settings.pm is generating absolute URIs for the thumbnail images. The above fix does make these use the correct (external) ip address rather than the internal docker one. However perhaps it makes more sense just to use a relative URL, like the rest of LMS?
ie, in JiveExtras/Settings.pm (sub _addSettings), change:
my $urlBase = Slim::Utils::Network::serverURL() . "/jive$optname";
to just:
my $urlBase = "/jive$optname";
Making this change also appears to fix things correctly, at least for wallpaper images (I haven't tested sounds)
from slimserver-platforms.
I was wondering about the relative vs. absolute URL. If you're saying it was working with the relative path, then that should be the way to go.
from slimserver-platforms.
I have similar request when I'm trying to use ipv6 address with the container.
Any concern about the extra args? If not I can help to create an PR for it.
from slimserver-platforms.
Related Issues (20)
- manifest unknown? HOT 4
- Feature Request: Optional install ffmpeg in docker container HOT 10
- Add libgomp1 to docker image
- FLAC playback fails HOT 2
- File limit is too low for larger playlists HOT 7
- Players lost after container restart HOT 8
- How to use port 5353 UDP on Synology? HOT 1
- Cannot connect to github lugin repository even impelemented with proxy HOT 7
- "latest" image on Docker Hub isn't HOT 1
- Point LMS to a different subnet with wifi devices on it? HOT 5
- Secret(s) found: 2 - [Product Security - Secret Scanning] HOT 5
- Docker - slow startup on systems with spinning disks results in stuck deployment on Kubernetes chart HOT 1
- EXTRA_ARGS is not passed to the startup script contrary to what documentation says for versions below 8.4
- Is the chown on /lms on startup actually neccessary? HOT 1
- Getting only "Operation is not permitted" errors HOT 2
- Implement migration path for Mac
- Implement migration path for Linux? HOT 1
- Implement migration path for Windows
- Rename all text strings to use new product name
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slimserver-platforms.