Enable sandbox on electron about zap-desktop HOT 4 CLOSED

Wow, very interesting @kewde. Thanks so much for taking the time to write this up. I am about to merge in a feature later today and then I will take a deeper dive 👍

from zap-desktop.

Cool, let me know if you have any issues with it!

I noticed that you already use a static channel 'lnd' for the IPC communication, so I don't think you'll have to completely overhaul the architecture to apply the sandbox.

Also another interesting security feature that you can add is a "payment confirmation model" on the backend. An exploit in the UI would be unable to bypass the payment confirmation model: an attacker that exploited an XSS vulnerability still can't steal any coins without user interaction. All communications are forced through IPC, and the backend would take care of the confirmation box. This assumes that the lnd-rpc is executed on the backend (main/browser process).

Here is a pseudocode

Clicked 'send Payment button' 
----> ipcRenderer.send('lnd', 'sendPayment + details) 
----> ipcMain.on('lnd', ..)
      ----> if( action === sendPayment) { 
                    open payment confirmation model
                           ----> if OK then execute payment through lnd rpc.
              }   

from zap-desktop.

Yeah so I took a deeper look, I think the architecture already supports sandbox support, since we moved away from Node/WS and went with ipcRenderer. I'll give it a try when I'm done with my current todo list.

Other security features like confirming payments should definitely be considered, but probably not until the MVP for testnet is done

from zap-desktop.

I've added an extended example that allows for multi-channel support (using a whitelist). Always happy to assist with any questions.

from zap-desktop.