Giter VIP home page Giter VIP logo

Comments (11)

GREsau avatar GREsau commented on September 24, 2024 3

The current latest causes the container's health checks to fail, although I think the container itself "works" correctly otherwise, i.e. it will response to AWS API requests as expected.

With this docker-compose.yml:

---
version: '3.8'

services:
  localstack:
    image: localstack/localstack:latest
    volumes:
      - "/var/run/docker.sock:/var/run/docker.sock"
    environment:
      - DEBUG=1

...running docker compose up --wait fails because the container never becomes healthy. There's nothing useful in the container logs, but when I start a shell in the container and manually invoke the healthcheck command (taken from here) directly I get an error, presumably related to the big code restructure you mentioned:

# ./bin/localstack status services --format=json
Traceback (most recent call last):
  File "/opt/code/localstack/./bin/localstack", line 23, in <module>
    main()
  File "/opt/code/localstack/./bin/localstack", line 17, in main
    from localstack.cli import main
ModuleNotFoundError: No module named 'localstack'

from localstack.

thrau avatar thrau commented on September 24, 2024 2

Thanks @GREsau, great catch. should be fixed with #10894

from localstack.

localstack-bot avatar localstack-bot commented on September 24, 2024

Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our Slack Community for real-time help and drop a message to LocalStack Pro Support if you are a Pro user! If you are willing to contribute towards fixing this issue, please have a look at our contributing guidelines and our contributing guide.

from localstack.

robo-corg avatar robo-corg commented on September 24, 2024

Using the tag localstack/localstack:3.4.0 seems to fix things

from localstack.

robo-corg avatar robo-corg commented on September 24, 2024

Confirmed that docker run localstack/localstack seems to break in a similar way

from localstack.

cloutierMat avatar cloutierMat commented on September 24, 2024

Thank you for reporting this issue.

There was a pretty big code restructure that just merged in today. While the image seems to be working and I can start the latest image locally, it is possible that you are running into some caching issues.

Can you try deleting your cache before re-triggering and let us know if that fixed the issue.

Also, docker run localstack/localstack is expected to show this error as you would need to mount the docker socket for docker to be available. See documentation

from localstack.

thrau avatar thrau commented on September 24, 2024

I can confirm there's a very loud exception about the docker socket not being mounted, but localstack still starts up fine.

are you having issues actually using localstack?

I don't think this has anything to do with the code restructuring. my guess would be that it has to do with the recent docker sdk upgrade from 6 to 7 https://github.com/localstack/localstack/pull/10853/files, but TBC

from localstack.

thrau avatar thrau commented on September 24, 2024

The issue reported by @robo-corg is actually related to #9761 and is expected behavior according to this change. Again I believe it's a non-issue since it's not affecting localstack in any way, but it's misleading because it suggests the startup failed. I think we should be providing better output. Something like:

LocalStack Docker information: Failed to inspect the LocalStack docker container. This is likely
because the docker socket was not mounted into the container. Without access to the docker socket,
LocalStack will not function properly. Please consult the LocalStack documentation on how to correctly
start up LocalStack, or run localstack with DEBUG=1 to find out why this error occurred.

cc @dominikschubert

from localstack.

robo-corg avatar robo-corg commented on September 24, 2024

Issue I encountered is that github considers the container to have not started up successfully. I didn't try actually using it since the tests never ran.

from localstack.

thrau avatar thrau commented on September 24, 2024

thanks for the clarification. in which case i think the startup issue you really had is fixed with #10894. the stack traces you reported are definitely misleading and are addressed in #10896

from localstack.

thrau avatar thrau commented on September 24, 2024

i'm closing this issue since the underlying issue (the healthcheck) has been fixed.

from localstack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.