Giter VIP home page Giter VIP logo

Comments (2)

anastassia-b avatar anastassia-b commented on May 20, 2024

Awesome work on this feature! I love the responsive ingredients list and the display of the baking times. The seed data is beautiful and the styling is impeccable. The recipe index page is complete, and you are finalizing the suggestion component on the recipe show page.

Based on our discussion today, here are some comments:

  • You could optionally user react-scroll to scroll to a precise location on the page and specify additional parameters.
  • Remove border-radius from the buttons to have a flat underline when active.
  • A quick fix for the nav-bar bunching up when the window resizes is to give it a min-width.

from food-stories.

locphan2207 avatar locphan2207 commented on May 20, 2024

In order to make the navigating buttons scroll to the correct positions, I created empty <div> and put them at correct positions. With those elements, I can use them as "stop points" for the scrolling.
By calling .scrollIntoView() on them, the navigating buttons can now bring users to correct positions.

from food-stories.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.