Comments (2)
Awesome work on this feature! I love the responsive ingredients list and the display of the baking times. The seed data is beautiful and the styling is impeccable. The recipe index page is complete, and you are finalizing the suggestion component on the recipe show page.
Based on our discussion today, here are some comments:
- You could optionally user react-scroll to scroll to a precise location on the page and specify additional parameters.
- Remove border-radius from the buttons to have a flat underline when active.
- A quick fix for the nav-bar bunching up when the window resizes is to give it a min-width.
from food-stories.
In order to make the navigating buttons scroll to the correct positions, I created empty <div>
and put them at correct positions. With those elements, I can use them as "stop points" for the scrolling.
By calling .scrollIntoView()
on them, the navigating buttons can now bring users to correct positions.
from food-stories.
Related Issues (12)
- Can a table have foreign keys from two tables? HOT 2
- PA Review: Likes HOT 2
- Comment bug
- Homepage Bug HOT 1
- PA Review: User Authentication HOT 3
- PA Review: Heroku HOT 3
- Session modal doesn't close to the correct path
- Canvas Bug HOT 1
- PA Review: Recipe Search HOT 2
- PA Review: Stories (Index and Showpage) HOT 1
- PA Review: Comment HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from food-stories.